-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align federated Deployment's observedGeneration semantics with its native #4867
Align federated Deployment's observedGeneration semantics with its native #4867
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4867 +/- ##
=======================================
Coverage 28.22% 28.22%
=======================================
Files 632 632
Lines 43431 43454 +23
=======================================
+ Hits 12259 12266 +7
- Misses 30278 30291 +13
- Partials 894 897 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @veophi can you help fix the lint error? |
/assign @yike21 |
f380479
to
cf79f5b
Compare
@XiShanYongYe-Chang fixed. |
Hi @veophi, Is this pr ready? If it is ready, you can remove the WIP info in the title. Then the work-in-progress label will be removed, indicating that the current pr is ready. In addition, you can add the issue number of the current pr to the end of
and GitHub will automatically associate it with the issue. After the pr is merged, the associated issue will be closed. |
cf79f5b
to
fa2364f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There are now stricter requirements for aligning the status.observedGeneration
of a federated resource (deployment) with its metadata.generation
.
Sometimes you may find that the status.observedGeneration
of federated resource (Deployment) is smaller than its metadata.generation
, meaning that some resource in member cluster have not yet been updated by deployment-controller, which is normal.
Thanks for you work! @veophi
fa2364f
to
68e7d2f
Compare
/assign |
62b976f
to
af6c762
Compare
fe73f93
to
64ca576
Compare
This pr has made some updates, can you help to have a look again? |
64ca576
to
5259f0c
Compare
Signed-off-by: 孙伟祥 <sunweixiang@xiaohongshu.com>
5259f0c
to
933343d
Compare
/lgtm @XiShanYongYe-Chang @whitewindmills @yike21 Do you have any further comments? |
Thanks a lot~ |
thanks a lot! |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Glad we finally made an aggrement!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #4870, #5021
Special notes for your reviewer:
Does this PR introduce a user-facing change?: