Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Umbrella] Align generation and observedGeneration fields by reflectstatus and aggregatestatus operation #4870

Closed
20 tasks done
yike21 opened this issue Apr 25, 2024 · 25 comments
Closed
20 tasks done

[Umbrella] Align generation and observedGeneration fields by reflectstatus and aggregatestatus operation #4870

yike21 opened this issue Apr 25, 2024 · 25 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v1.11

Comments

@yike21
Copy link
Member

yike21 commented Apr 25, 2024 •
edited

What would you like to be added:
There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help
@yike21 yike21 added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 25, 2024
@karmada-bot
Copy link
Collaborator

@yike21:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added:
There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

  • native resource
  • GroupVersion: apps/v1
    kind:
  • Thirdparty resource
  • GroupVersion: apps.kruise.io/v1alpha1
    kind:
    • CloneSet
    • DaemonSet
  • GroupVersion: apps.kruise.io/v1beta1
    kind:
    • StatefulSet
  • GroupVersion: helm.toolkit.fluxcd.io/v2beta1
    kind:
    • HelmRelease
  • GroupVersion: kustomize.toolkit.fluxcd.io/v1
    kind:
    • Kustomization
  • GroupVersion: source.toolkit.fluxcd.io/v1
    kind:
    • GitRepository
  • GroupVersion: source.toolkit.fluxcd.io/v1beta2
    kind:
    • Bucket
    • HelmChart
    • HelmRepository
    • OCIRepository

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karmada-bot karmada-bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 25, 2024
@liangyuanpeng
Copy link
Contributor

I want to try it for StatefulSet

@yike21
Copy link
Member Author

yike21 commented Apr 25, 2024

I want to try it for StatefulSet

Thanks a lot~

@XiShanYongYe-Chang
Copy link
Member

@yike21 Good Job!

This was referenced Apr 25, 2024
Merged
Closed
@whitewindmills
Copy link
Member

I wanna pick up DaemonSet, thanks.

@yike21
Copy link
Member Author

yike21 commented Apr 26, 2024

I wanna pick up DaemonSet, thanks.

ok, thanks a lot~

@zhy76
Copy link
Member

zhy76 commented May 30, 2024

I am also concerned about this question. What is the current progress of cloneset? I can get involved in this issue about other resource, too

@XiShanYongYe-Chang
Copy link
Member

It will continue to advance in the next version.

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this issue Jun 14, 2024
Open
4 tasks
@RainbowMango RainbowMango added this to the v1.11 milestone Jun 17, 2024
@XiShanYongYe-Chang
Copy link
Member

Hello everyone, we can continue this issue.
@veophi @yike21 @whitewindmills @liangyuanpeng

@veophi veophi mentioned this issue Jun 17, 2024
Merged
@Akash-Singh04
Copy link
Contributor

Hey is this issue still open? if so, I would like to work on it

@yike21
Copy link
Member Author

yike21 commented Jun 18, 2024

Hey is this issue still open? if so, I would like to work on it

Thanks! you can choose what you are interested in.

@zhy76
Copy link
Member

zhy76 commented Jun 18, 2024

Can I work on apps.kruise.io/v1beta1 statefulset?

@yike21
Copy link
Member Author

yike21 commented Jun 18, 2024

Can I work on apps.kruise.io/v1beta1 statefulset?

ok, thanks a lot~

@Akash-Singh04
Copy link
Contributor

Can we get started on this issue or should we wait for #5057 to be completed? I would like to work on helm.toolkit.fluxcd.io/v2beta1

@yike21
Copy link
Member Author

yike21 commented Jun 22, 2024

Can we get started on this issue or should we wait for #5057 to be completed? I would like to work on helm.toolkit.fluxcd.io/v2beta1

Thanks, let's start this issue! We need to modify AggregateStatus and statusReflection, then update testdata to characterize the new customizations.

This was referenced Jun 22, 2024
Merged
Merged
@zhy76 zhy76 mentioned this issue Jun 24, 2024
Merged
@liangyuanpeng
Copy link
Contributor

Hello everyone, we can continue this issue.
@veophi @yike21 @whitewindmills @liangyuanpeng

I will open a PR for StatefulSet in this week.

This was referenced Jul 10, 2024
Merged
Merged
This was referenced Jul 13, 2024
Merged
Merged
This was referenced Jul 14, 2024
Merged
Merged
@liangyuanpeng liangyuanpeng mentioned this issue Jul 16, 2024
Merged
@RainbowMango
Copy link
Member

/reopen
as closed by #5196 by mistake.

@karmada-bot karmada-bot reopened this Jul 19, 2024
@karmada-bot
Copy link
Collaborator

@RainbowMango: Reopened this issue.

In response to this:

/reopen
as closed by #5196 by mistake.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@XiShanYongYe-Chang
Copy link
Member

Kind ping @Akash-Singh04, do you have time to make a PR?

@XiShanYongYe-Chang
Copy link
Member

Hi @yike21, we have one sub-mission left.

@yike21
Copy link
Member Author

yike21 commented Jul 29, 2024

Hi @yike21, we have one sub-mission left.

Hi @XiShanYongYe-Chang ! Let's wait a little bit for @Akash-Singh04 . If Akash-Singh04 is busy, I'll finish this part as soon as possible during the week.

@Akash-Singh04
Copy link
Contributor

Hey @XiShanYongYe-Chang Currently busy, feel free to make a PR :)

@yike21 yike21 mentioned this issue Aug 6, 2024
Merged
@RainbowMango
Copy link
Member

It seems all tasks are done. Great job! @yike21
Thanks to everyone who contribute to this task.
/close

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closing this issue.

In response to this:

It seems all tasks are done. Great job! @yike21
Thanks to everyone who contribute to this task.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yike21
Copy link
Member Author

yike21 commented Aug 9, 2024

Thank you all for the contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Karmada Overall Backlog
Status: Planned In Release 1.11
Milestone
v1.11
Development

No branches or pull requests
8 participants
@RainbowMango @liangyuanpeng @yike21 @zhy76 @karmada-bot @XiShanYongYe-Chang @whitewindmills @Akash-Singh04