Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align federated StatefulSet's observedGeneration semantics with its native #5204

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

liangyuanpeng
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
/kind feature

Which issue(s) this PR fixes:
part of #4870

/cc @yike21 @XiShanYongYe-Chang

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Mark `.status.observedGeneration` of StatefulSet with `.metadata.generation` only when all members' statuses are algined with its resource template generation.

…ative

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2024
Comment on lines +313 to 316
newStatus.ObservedGeneration = oldStatus.ObservedGeneration
if observedLatestResourceTemplateGenerationCount == len(aggregatedStatusItems) {
newStatus.ObservedGeneration = daemonSet.Generation
} else {
newStatus.ObservedGeneration = oldStatus.ObservedGeneration
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reduce unnecessary code of else, happy to have different opinions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay~

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 44.11765% with 19 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (d4c5890) to head (0de6b28).

Files Patch % Lines
...esourceinterpreter/default/native/reflectstatus.go 0.00% 18 Missing ⚠️
...ourceinterpreter/default/native/aggregatestatus.go 93.75% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5204      +/-   ##
==========================================
+ Coverage   28.23%   28.25%   +0.01%     
==========================================
  Files         632      632              
  Lines       43712    43728      +16     
==========================================
+ Hits        12343    12354      +11     
- Misses      30467    30474       +7     
+ Partials      902      900       -2     
Flag Coverage Δ
unittests 28.25% <44.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot
/lgtm
/assign @yike21

@yike21
Copy link
Member

yike21 commented Jul 17, 2024

Thanks!
LGTM

@XiShanYongYe-Chang
Copy link
Member

Thanks @yike21
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@karmada-bot karmada-bot merged commit 1bf9336 into karmada-io:master Jul 18, 2024
12 checks passed
@pulsarsigs-bot pulsarsigs-bot deleted the statefulset_generation branch July 18, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants