-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align federated StatefulSet's observedGeneration semantics with its native #5204
Align federated StatefulSet's observedGeneration semantics with its native #5204
Conversation
…ative Signed-off-by: Lan Liang <gcslyp@gmail.com>
newStatus.ObservedGeneration = oldStatus.ObservedGeneration | ||
if observedLatestResourceTemplateGenerationCount == len(aggregatedStatusItems) { | ||
newStatus.ObservedGeneration = daemonSet.Generation | ||
} else { | ||
newStatus.ObservedGeneration = oldStatus.ObservedGeneration | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for reduce unnecessary code of else, happy to have different opinions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay~
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5204 +/- ##
==========================================
+ Coverage 28.23% 28.25% +0.01%
==========================================
Files 632 632
Lines 43712 43728 +16
==========================================
+ Hits 12343 12354 +11
- Misses 30467 30474 +7
+ Partials 902 900 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
/lgtm
/assign @yike21
Thanks! |
Thanks @yike21 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
/kind feature
Which issue(s) this PR fixes:
part of #4870
/cc @yike21 @XiShanYongYe-Chang
Special notes for your reviewer:
Does this PR introduce a user-facing change?: