Align federated helmcharts.source.toolkit.fluxcd.io observedGeneration semantics with its native #5194
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
…n semantics with its native Signed-off-by: yike21 <yike21@qq.com>
yike21
force-pushed
the
generation-helmchart
branch
from
cd83e36
to
b92029c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
=======================================
Coverage 28.23% 28.24%
=======================================
Files 632 632
Lines 43712 43712
=======================================
+ Hits 12344 12345 +1
Misses 30465 30465
+ Partials 903 902 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| if statusItems[i].status ~= nil and statusItems[i].status.lastHandledReconcileAt ~= nil and statusItems[i].status.lastHandledReconcileAt ~= '' then | ||
| desiredObj.status.lastHandledReconcileAt = statusItems[i].status.lastHandledReconcileAt |
There was a problem hiding this comment.
When we add a field that does not exist in status, the program does not report an error, right?
There was a problem hiding this comment.
Yes, in this case statusItems[i].status.lastHandledReconcileAt was equal to nil and these two lines would be skipped.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #4870
Special notes for your reviewer:
Does this PR introduce a user-facing change?: