cleanup dead code of generating Work permanent id #4928
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/S
|
The test is failing. |
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
whitewindmills
force-pushed
the
work-id-generation
branch
from
4df0bf1
to
93a04cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4928 +/- ##
==========================================
- Coverage 53.18% 53.17% -0.01%
==========================================
Files 252 252
Lines 20510 20508 -2
==========================================
- Hits 10909 10906 -3
Misses 8882 8882
- Partials 719 720 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
please take a look @RainbowMango @XiShanYongYe-Chang |
|
This breaks version compatibility, it is recommended to add releast-note for this. |
|
@liangyuanpeng The feature version that enables work permanent ID has not been released yet. |
|
thanks for the clarification,make sense! |
|
/retitle cleanup dead code of generating Work permanent id |
karmada-bot
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Since the PR(#4474) has been merged, we're going to remove those codes which generate work permanent ID outside of webhook.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: