-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup dead code of generating binding permanent id #4950
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4950 +/- ##
==========================================
+ Coverage 53.23% 53.28% +0.05%
==========================================
Files 252 252
Lines 20514 20503 -11
==========================================
+ Hits 10921 10926 +5
+ Misses 8869 8854 -15
+ Partials 724 723 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @whitewindmills the E2E is failed. |
seems to be an unrelated e2e case. |
Hi @whitewindmills I want to confirm that the logic for generating permanent-id in the controller is removed in this version, which does not affect the upgrade from version 1.8 to version 1.9? |
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
f873dc1
to
a9f3c02
Compare
I don't think it will. this commit will only be released after v1.10+. |
Thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
/cc @chaunceyjiang |
/assign @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
fix golint issue introduced by #4950
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Since the PR(#4474) has been merged, we're going to remove those codes which generate binding permanent ID outside of webhook.
Same as #4928
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: