Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup dead code of generating binding permanent id #4950

Merged
merged 1 commit into from
May 21, 2024

Conversation

whitewindmills
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Since the PR(#4474) has been merged, we're going to remove those codes which generate binding permanent ID outside of webhook.
Same as #4928

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 16, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2024
@whitewindmills
Copy link
Member Author

/cc @XiShanYongYe-Chang

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.28%. Comparing base (b217a9c) to head (f873dc1).

Files Patch % Lines
...ependenciesdistributor/dependencies_distributor.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4950      +/-   ##
==========================================
+ Coverage   53.23%   53.28%   +0.05%     
==========================================
  Files         252      252              
  Lines       20514    20503      -11     
==========================================
+ Hits        10921    10926       +5     
+ Misses       8869     8854      -15     
+ Partials      724      723       -1     
Flag Coverage Δ
unittests 53.28% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Hi @whitewindmills the E2E is failed.

@whitewindmills
Copy link
Member Author

seems to be an unrelated e2e case.
/retest

@XiShanYongYe-Chang
Copy link
Member

Hi @whitewindmills I want to confirm that the logic for generating permanent-id in the controller is removed in this version, which does not affect the upgrade from version 1.8 to version 1.9?

Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
@whitewindmills
Copy link
Member Author

which does not affect the upgrade from version 1.8 to version 1.9?

I don't think it will. this commit will only be released after v1.10+.

@XiShanYongYe-Chang
Copy link
Member

Thanks~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@XiShanYongYe-Chang
Copy link
Member

/cc @chaunceyjiang

@whitewindmills
Copy link
Member Author

/assign @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@karmada-bot karmada-bot merged commit 1ebaf1d into karmada-io:master May 21, 2024
12 checks passed
@whitewindmills whitewindmills deleted the bindID-webhook branch May 21, 2024 02:35
RainbowMango added a commit to RainbowMango/karmada that referenced this pull request May 21, 2024
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
karmada-bot added a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants