-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix golint issue introduced by #4950 #4966
fix golint issue introduced by #4950 #4966
Conversation
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4966 +/- ##
==========================================
+ Coverage 53.30% 53.34% +0.03%
==========================================
Files 252 252
Lines 20489 20478 -11
==========================================
+ Hits 10922 10924 +2
+ Misses 8845 8832 -13
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
#4950 introduced a lint issue which will block PRs:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Haven't figured out why CI cannot detect it at #4950.
cc @whitewindmills
Does this PR introduce a user-facing change?: