-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for unschedulable plugin result during maxreplica estimation #5012
Account for unschedulable plugin result during maxreplica estimation #5012
Conversation
Welcome @mszacillo! It looks like this is your first PR to karmada-io/karmada 🎉 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5012 +/- ##
==========================================
- Coverage 53.32% 53.30% -0.03%
==========================================
Files 253 253
Lines 20560 20565 +5
==========================================
- Hits 10964 10962 -2
- Misses 8870 8876 +6
- Partials 726 727 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
6494963
to
957e50b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
957e50b
to
34be0c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@whitewindmills Do you have any further comments?
others LGTM |
Signed-off-by: mszacillo <mszacillo@bloomberg.net>
34be0c4
to
23c9dc9
Compare
Thanks for all the comments! |
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mszacillo Great thanks for helping fix this! |
Filed an issue(#5024) to track the backport tasks. |
@mszacillo I didn't run the test locally, can you confirm if this patch works as expected? |
…5012-upstream-release-1.10 Automated cherry pick of #5012: Account for unschedulable plugin result during maxreplica
…5012-upstream-release-1.9 Automated cherry pick of #5012: Account for unschedulable plugin result during maxreplica
What type of PR is this?
/kind bug
What this PR does / why we need it:
Bugfix related to maxReplica estimation.
Testing
Local:
E2E test with added logs:
Which issue(s) this PR fixes:
Fixes #5011
Special notes for your reviewer:
Does this PR introduce a user-facing change?: