Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5012: Account for unschedulable plugin result during maxreplica #5027

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Jun 6, 2024

Cherry pick of #5012 on release-1.10.
#5012: Account for unschedulable plugin result during maxreplica
For details on the cherry pick process, see the cherry pick requests page.

`karmada-scheduler-estimator`: Fixed the `Unschedulable` result returned by plugins to be treated as an exception issue.

Signed-off-by: mszacillo <mszacillo@bloomberg.net>
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2024
@RainbowMango RainbowMango mentioned this pull request Jun 6, 2024
3 tasks
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.30%. Comparing base (c181917) to head (185770a).

Files Patch % Lines
pkg/estimator/server/estimate.go 0.00% 1 Missing and 1 partial ⚠️
pkg/scheduler/core/util.go 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #5027      +/-   ##
================================================
- Coverage         53.32%   53.30%   -0.03%     
================================================
  Files               253      253              
  Lines             20560    20565       +5     
================================================
- Hits              10964    10962       -2     
- Misses             8870     8876       +6     
- Partials            726      727       +1     
Flag Coverage Δ
unittests 53.30% <62.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 12, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 7c13dbb into karmada-io:release-1.10 Jun 12, 2024
12 checks passed
@RainbowMango RainbowMango deleted the automated-cherry-pick-of-#5012-upstream-release-1.10 branch August 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants