Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci 1.10 #5083

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Update ci 1.10 #5083

merged 2 commits into from
Jun 24, 2024

Conversation

08AHAD
Copy link
Contributor

@08AHAD 08AHAD commented Jun 22, 2024 •
edited by RainbowMango
Loading

/kind cleanup
/kind cleanup: Update CI for Karmada 1.10 and remove release-1.7

Fixes #5060

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 22, 2024
@karmada-bot
Copy link
Collaborator

@08AHAD: The label(s) kind/cleanup:, kind/update, kind/ci, kind/for, kind/karmada, kind/1.10, kind/and, kind/remove, kind/release-1.7 cannot be applied, because the repository doesn't have them.

In response to this:

/kind cleanup
/kind cleanup: Update CI for Karmada 1.10 and remove release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2024
08AHAD added 2 commits June 22, 2024 17:38
@08AHAD
/kind cleanup: Update CI for Karmada 1.10 and remove release-1.7
27b501b 
Signed-off-by: 08AHAD <91091911+08AHAD@users.noreply.github.com>
@08AHAD
/kind cleanup: Update CI for Karmada 1.10 and remove release-1.7 in c…
3b66dcd 
…i-schedule-compability.yaml

Signed-off-by: 08AHAD <91091911+08AHAD@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@0bc96a2). Learn more about missing BASE report.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #5083   +/-   ##
=========================================
  Coverage          ?   28.22%           
=========================================
  Files             ?      632           
  Lines             ?    43551           
  Branches          ?        0           
=========================================
  Hits              ?    12291           
  Misses            ?    30364           
  Partials          ?      896
Flag Coverage Δ
unittests 28.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango mentioned this pull request Jun 24, 2024
Merged
@RainbowMango RainbowMango added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 24, 2024
RainbowMango
RainbowMango approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@karmada-bot karmada-bot merged commit 1255a08 into karmada-io:master Jun 24, 2024
12 checks passed
@RainbowMango RainbowMango mentioned this pull request Jun 24, 2024
Closed
@08AHAD 08AHAD deleted the update-ci-1.10 branch June 24, 2024 08:28
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
SkySingh04 pushed a commit to SkySingh04/karmada that referenced this pull request Dec 31, 2024
@08AHAD @SkySingh04
Update ci 1.10 (karmada-io#5083)
79033e5 
* /kind cleanup: Update CI for Karmada 1.10 and remove release-1.7

Signed-off-by: 08AHAD <91091911+08AHAD@users.noreply.github.com>

* /kind cleanup: Update CI for Karmada 1.10 and remove release-1.7 in ci-schedule-compability.yaml

Signed-off-by: 08AHAD <91091911+08AHAD@users.noreply.github.com>

---------

Signed-off-by: 08AHAD <91091911+08AHAD@users.noreply.github.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@jwcesign jwcesign Awaiting requested review from jwcesign

@liangyuanpeng liangyuanpeng Awaiting requested review from liangyuanpeng

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Update CI for release-1.10 on master
4 participants
@08AHAD @karmada-bot @codecov-commenter @RainbowMango