Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for release-1.10 on master #5060

Closed
liangyuanpeng opened this issue Jun 18, 2024 · 9 comments · Fixed by #5083
Closed

Update CI for release-1.10 on master #5060

liangyuanpeng opened this issue Jun 18, 2024 · 9 comments · Fixed by #5083
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Jun 18, 2024

Task description:

karmada 1.10 is live, so we need to update the CI for release-1.10, basically, you need to delete release-1.7 and add the last release-1.10

- package-ecosystem: docker
directory: /cluster/images/
target-branch: "release-1.9"
schedule:
interval: weekly
- package-ecosystem: docker
directory: /cluster/images/
target-branch: "release-1.8"
schedule:
interval: weekly
- package-ecosystem: docker
directory: /cluster/images/
target-branch: "release-1.7"
schedule:
interval: weekly

karmada-version: [ release-1.7, release-1.8, release-1.9 ]

cc some people who may be interested @Akash-Singh04

Solution:

Who can join or take the task:

The good first issue is intended for first-time contributors to get started on his/her contributor journey.

After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to help wanted items, saving the remaining good first issue for other new contributors.

How to join or take the task:

Just reply on the issue with the message /assign in a separate line.

Then, the issue will be assigned to you.

How to ask for help:

If you need help or have questions, please feel free to ask on this issue.
The issue author or other members of the community will guide you through the contribution process.

@liangyuanpeng liangyuanpeng added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 18, 2024
@08AHAD
Copy link
Contributor

08AHAD commented Jun 18, 2024

/assign
Please assign me this issue.

@08AHAD
Copy link
Contributor

08AHAD commented Jun 18, 2024

I am facing problem in pull request

@SkySingh04
Copy link
Contributor

Sure, will work on this!

@SkySingh04
Copy link
Contributor

/assign

@XiShanYongYe-Chang
Copy link
Member

Thanks @Akash-Singh04
ref #5062

SkySingh04 added a commit to SkySingh04/karmada that referenced this issue Jun 18, 2024
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
@SkySingh04
Copy link
Contributor

@XiShanYongYe-Chang Kindly review the PR and let me know if any further changes are required

@08AHAD
Copy link
Contributor

08AHAD commented Jun 18, 2024

@08AHAD
Copy link
Contributor

08AHAD commented Jun 18, 2024

I have also reaaranged the code that is asked later please review my PR @liangyuanpeng

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Jun 19, 2024

@08AHAD @Akash-Singh04

Thank you for your enthusiasm! Since this is a good first issue, I hope to follow the first-come-first-served principle (first assigner) . So I may choose the PR submitted by @08AHAD . If @08AHAD doesn't follow through, someone else can take over and finish the job.

we have other issue can be choice, #4929 is ready to go @Akash-Singh04 if you are Interested in this :)

@liangyuanpeng liangyuanpeng changed the title Update CI for release-1.10 Update CI for release-1.10 on master Jun 19, 2024
SkySingh04 added a commit to SkySingh04/karmada that referenced this issue Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants