Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-picks: 4899 let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4929

Closed
3 tasks done
liangyuanpeng opened this issue May 11, 2024 · 8 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented May 11, 2024

Which PR needs cherry-picks:

PR #4899

PR is changing the files of artifacts/deploy and hack, it need to cherry pick the change to release branch and then it can be work for workflow APIServer compatibility

/assign

Which release branches need this patch:

How to cherry-pick PRs:

The hack/cherry_pick_pull.sh script can help you initiate a cherry-pick
automatically, please follow the instructions at this guideline.

The script will send the PR for you, please remember copy the release notes from
the original PR by to the new PR description part.

How to join or take the task:

Just reply on the issue with the message /assign in a separate line.

Then, the issue will be assigned to you.

Useful References:

Anything else we need to know:

@liangyuanpeng liangyuanpeng added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 11, 2024
@SkySingh04
Copy link
Contributor

Hey is this issue still open? I would like to work on it

@liangyuanpeng
Copy link
Contributor Author

@Akash-Singh04 ready to go, please feel free to pick it up :)

@SkySingh04
Copy link
Contributor

/assign

@liangyuanpeng
Copy link
Contributor Author

kindly ping @Akash-Singh04

@SkySingh04
Copy link
Contributor

working on this, will be done by EOD

@SkySingh04
Copy link
Contributor

@liangyuanpeng #5134 #5133 #5132 have been made, kindly review them and let me know if any further changes are required

@RainbowMango
Copy link
Member

/close
as all tasks are done. thanks, @Akash-Singh04 for the effort.

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closing this issue.

In response to this:

/close
as all tasks are done. thanks, @Akash-Singh04 for the effort.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants