-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #4899: chore: let kube version of artifaces/deploy/karmada-apiserver #5133
Automated cherry pick of #4899: chore: let kube version of artifaces/deploy/karmada-apiserver #5133
Conversation
… support configuration. Signed-off-by: Lan Liang <gcslyp@gmail.com>
hack/deploy-karmada.sh
Outdated
@@ -200,8 +200,10 @@ fi | |||
# deploy karmada apiserver | |||
TEMP_PATH_APISERVER=$(mktemp -d) | |||
trap '{ rm -rf ${TEMP_PATH_APISERVER}; }' EXIT | |||
KARMADA_APISERVER_VERSION=${KARMADA_APISERVER_VERSION:-"v1.27.11"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KARMADA_APISERVER_VERSION=${KARMADA_APISERVER_VERSION:-"v1.27.11"} | |
KARMADA_APISERVER_VERSION=${KARMADA_APISERVER_VERSION:-"v1.26.12"} |
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
I see all comments resolved.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #4899 on release-1.9.
#4899: chore: let kube version of artifaces/deploy/karmada-apiserver
For details on the cherry pick process, see the cherry pick requests page.