chore: let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4899

liangyuanpeng · 2024-05-04T11:47:02Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The workflow of APIServer compatibility is failing when it's running with master, see

The reason is master is running with karmada-apiserver v1.27.11, and the workflow of APIServer compatibility is change the version of karmada-apiserver by patching karmada-apiserver, and actually it's happening the downgrade/upgrade of karmada-apiserver, it's always failing if karmada-apiserver have add some new API. For now, it's flowcontrol.apiserver.k8s.io/v1beta3,
available with v1.26, so it will always failed if karmada-apiserver downgrade to lessthan v1.26

So this PR is working for useing environment to config the karmada-apiserver version, Avoid karmada-apiserver downgrade/upgrade happening.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

This PR CI is failing with the confict artifact name, will resolve by #4897

Does this PR introduce a user-facing change?:

codecov-commenter · 2024-05-04T11:58:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (a8697ec) to head (9a32daa).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4899      +/-   ##
==========================================
+ Coverage   53.12%   53.14%   +0.01%     
==========================================
  Files         251      251              
  Lines       20415    20415              
==========================================
+ Hits        10845    10849       +4     
+ Misses       8856     8853       -3     
+ Partials      714      713       -1

Flag	Coverage Δ
unittests	`53.14% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RainbowMango · 2024-05-08T01:33:58Z

cc @zhzhuang-zju

zhzhuang-zju

Thanks for your important commit! Review is ongoing, and my viewpoint just for reference only.

artifacts/deploy/karmada-apiserver.yaml

artifacts/deploy/kube-controller-manager.yaml

hack/deploy-karmada.sh

zhzhuang-zju · 2024-05-08T03:41:42Z

@liangyuanpeng By looking at the logs uploaded by CI, I found that the versions of karmada-apiserver are both v1.25.4 and have not changed based on the configured environment variables. Can you help confirm this?

liangyuanpeng · 2024-05-08T04:04:07Z

we need to cherry pick this change to branch of release, and then it can be working for release branch, i update the trigger branch to master for verify.

zhzhuang-zju · 2024-05-08T06:33:59Z

we need to cherry pick this change to branch of release, a

Yes, changes to files karmada-apiserver.yaml, kube-controller-manager.yamland deploy-karmada.sh should be synchronized to previous release versions.

@liangyuanpeng It would be nice to have an issue to break down and track this task, which would also make the whole work clearer

liangyuanpeng · 2024-05-11T03:22:51Z

tracking at #4929

… support configuration. Signed-off-by: Lan Liang <gcslyp@gmail.com>

liangyuanpeng · 2024-06-18T09:10:06Z

Delete the changes of .github/workflows/ci-schedule-compatibility.yaml for clean cherrypick and leave it to the next PR.

zhzhuang-zju · 2024-06-18T11:54:08Z

thanks
/lgtm
cc @RainbowMango

RainbowMango

/assign

RainbowMango

/approve
I can tell with this patch, we can specify which kube-apiserver should be used during look up, and we don't need to update images afterwards

RainbowMango · 2024-06-19T01:52:12Z

hack/deploy-karmada.sh

@@ -200,8 +200,10 @@ fi
 # deploy karmada apiserver
 TEMP_PATH_APISERVER=$(mktemp -d)
 trap '{ rm -rf ${TEMP_PATH_APISERVER}; }' EXIT
+KARMADA_APISERVER_VERSION=${KARMADA_APISERVER_VERSION:-"v1.27.11"}


Is there a plan to bump this to v1.28?

yes, i will open a PR for it ASAP.

Thanks.
I'm asking this because I guess the default version of karmadactl init/operator/chart might need to update as well.

I hope that the default version of karmada-apiserver will be consistent with the version of the dependent go module (WDYT), and will catch up to be consistent ASAP.

That's a good idea if you mean the version of the k8s.io/xxx dependencies in go.mod file.

k8s.io/client-go version VS kube-apiserver version

karmada-bot · 2024-06-19T01:55:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…#4899-upstream-release-1.8 Automated cherry pick of #4899: chore: let kube version of artifaces/deploy/karmada-apiserver

…#4899-upstream-release-1.10 Automated cherry pick of #4899: chore: let kube version of artifaces/deploy/karmada-apiserver

…deploy/karmada-apiserver (#5133) * chore: let kube version of artifaces/deploy/karmada-apiserver version support configuration. Signed-off-by: Lan Liang <gcslyp@gmail.com> * Updated version in deploy-karmadda.sh Signed-off-by: Akash Singh <akashsingh2210670@gmail.com> --------- Signed-off-by: Lan Liang <gcslyp@gmail.com> Signed-off-by: Akash Singh <akashsingh2210670@gmail.com> Co-authored-by: Lan Liang <gcslyp@gmail.com>

karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 4, 2024

karmada-bot requested review from Garrybest and zhzhuang-zju May 4, 2024 11:47

karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2024

karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2024

liangyuanpeng force-pushed the artifact_kubeversion_param branch from 11b00c4 to c4bbedf Compare May 7, 2024 14:37

karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label May 7, 2024

liangyuanpeng force-pushed the artifact_kubeversion_param branch from c4bbedf to 3273fde Compare May 7, 2024 14:38

zhzhuang-zju reviewed May 8, 2024

View reviewed changes

artifacts/deploy/karmada-apiserver.yaml Outdated Show resolved Hide resolved

artifacts/deploy/kube-controller-manager.yaml Outdated Show resolved Hide resolved

hack/deploy-karmada.sh Outdated Show resolved Hide resolved

liangyuanpeng force-pushed the artifact_kubeversion_param branch from 3273fde to a75277a Compare May 8, 2024 04:02

karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2024

liangyuanpeng mentioned this pull request May 11, 2024

cherry-picks: 4899 let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4929

Closed

3 tasks

liangyuanpeng force-pushed the artifact_kubeversion_param branch 3 times, most recently from 45e349a to 771e331 Compare June 18, 2024 09:03

karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2024

chore: let kube version of artifaces/deploy/karmada-apiserver version…

8e43753

… support configuration. Signed-off-by: Lan Liang <gcslyp@gmail.com>

liangyuanpeng force-pushed the artifact_kubeversion_param branch from 771e331 to 8e43753 Compare June 18, 2024 09:08

karmada-bot assigned zhzhuang-zju Jun 18, 2024

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024

RainbowMango reviewed Jun 19, 2024

View reviewed changes

karmada-bot assigned RainbowMango Jun 19, 2024

RainbowMango approved these changes Jun 19, 2024

View reviewed changes

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024

karmada-bot merged commit 6fba282 into karmada-io:master Jun 19, 2024
12 checks passed

pulsarsigs-bot deleted the artifact_kubeversion_param branch June 19, 2024 01:55

karmada-bot added a commit that referenced this pull request Jul 4, 2024

Merge pull request #5132 from Akash-Singh04/automated-cherry-pick-of-…

4153648

…#4899-upstream-release-1.8 Automated cherry pick of #4899: chore: let kube version of artifaces/deploy/karmada-apiserver

karmada-bot added a commit that referenced this pull request Jul 4, 2024

Merge pull request #5134 from Akash-Singh04/automated-cherry-pick-of-…

a65e791

…#4899-upstream-release-1.10 Automated cherry pick of #4899: chore: let kube version of artifaces/deploy/karmada-apiserver

RainbowMango added this to the v1.11 milestone Aug 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4899

chore: let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4899

liangyuanpeng commented May 4, 2024 •

edited

Loading

codecov-commenter commented May 4, 2024 •

edited

Loading

RainbowMango commented May 8, 2024

zhzhuang-zju left a comment

zhzhuang-zju commented May 8, 2024

liangyuanpeng commented May 8, 2024

zhzhuang-zju commented May 8, 2024

liangyuanpeng commented May 11, 2024

liangyuanpeng commented Jun 18, 2024

zhzhuang-zju commented Jun 18, 2024

RainbowMango left a comment

RainbowMango left a comment

RainbowMango Jun 19, 2024

liangyuanpeng Jun 19, 2024

RainbowMango Jun 19, 2024

liangyuanpeng Jun 19, 2024

RainbowMango Jun 19, 2024

RainbowMango Jun 19, 2024

karmada-bot commented Jun 19, 2024

chore: let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4899

chore: let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4899

Conversation

liangyuanpeng commented May 4, 2024 • edited Loading

codecov-commenter commented May 4, 2024 • edited Loading

Codecov Report

RainbowMango commented May 8, 2024

zhzhuang-zju left a comment

Choose a reason for hiding this comment

zhzhuang-zju commented May 8, 2024

liangyuanpeng commented May 8, 2024

zhzhuang-zju commented May 8, 2024

liangyuanpeng commented May 11, 2024

liangyuanpeng commented Jun 18, 2024

zhzhuang-zju commented Jun 18, 2024

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango Jun 19, 2024

Choose a reason for hiding this comment

liangyuanpeng Jun 19, 2024

Choose a reason for hiding this comment

RainbowMango Jun 19, 2024

Choose a reason for hiding this comment

liangyuanpeng Jun 19, 2024

Choose a reason for hiding this comment

RainbowMango Jun 19, 2024

Choose a reason for hiding this comment

RainbowMango Jun 19, 2024

Choose a reason for hiding this comment

karmada-bot commented Jun 19, 2024

liangyuanpeng commented May 4, 2024 •

edited

Loading

codecov-commenter commented May 4, 2024 •

edited

Loading