-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for corev1.LoadBalancerIngress,add IP model to VIP when ip is setting. #5141
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5141 +/- ##
==========================================
- Coverage 28.22% 28.22% -0.01%
==========================================
Files 632 632
Lines 43553 43553
==========================================
- Hits 12293 12291 -2
- Misses 30364 30365 +1
- Partials 896 897 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2aa67d0
to
ee75b16
Compare
Support, so that incompatibilities can be detected as early as possible |
That's weird, workflow |
Update the test for it, the feature gate LoadBalancerIPMode is beta at v1.30, see https://github.com/kubernetes/kubernetes/blob/95debfb5b6dcfa2467f2700d81df6767a2c91bac/pkg/features/kube_features.go#L903-L908 |
@liangyuanpeng This change may need to be synchronized to release-1.10. Can you remind me why release-1.8 and release-1.9 are seems not affected? Refer to https://github.com/karmada-io/karmada/actions/runs/9734577204/job/26862785337, |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes
@zhzhuang-zju |
thanks, get it~ |
6154d97
to
f4699dc
Compare
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
since kubernetes 1.30 begin set IPMode of LoadBalancer service to VIP by default if IP is setting, So we need to set the IPMode to VIP for test.
check failing tests: https://github.com/karmada-io/karmada/actions/runs/9734577204/job/26862785337
check the kubernetes side: https://github.com/kubernetes/kubernetes/blob/d27e3462baa419532209a7515bd24de36b2a5020/pkg/apis/core/v1/defaults.go#L147-L151
also can check the reproduce workflow: https://github.com/karmada-io/karmada/actions/runs/9804835683/job/27073502218?pr=5141
just change the karmada-apiserver to v1.30.0 for reproduce it.
and i open a PR #5142 to adding the master branch to run karmada-apiserver compatibility workflow, So that we can find karmada-apiserver compatibility issues on the master branch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: