Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for corev1.LoadBalancerIngress,add IP model to VIP when ip is setting. #5141

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Jul 5, 2024

What type of PR is this?

/kind failing-test
What this PR does / why we need it:

since kubernetes 1.30 begin set IPMode of LoadBalancer service to VIP by default if IP is setting, So we need to set the IPMode to VIP for test.
check failing tests: https://github.com/karmada-io/karmada/actions/runs/9734577204/job/26862785337

check the kubernetes side: https://github.com/kubernetes/kubernetes/blob/d27e3462baa419532209a7515bd24de36b2a5020/pkg/apis/core/v1/defaults.go#L147-L151

also can check the reproduce workflow: https://github.com/karmada-io/karmada/actions/runs/9804835683/job/27073502218?pr=5141

just change the karmada-apiserver to v1.30.0 for reproduce it.

and i open a PR #5142 to adding the master branch to run karmada-apiserver compatibility workflow, So that we can find karmada-apiserver compatibility issues on the master branch.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 5, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2024
@liangyuanpeng liangyuanpeng changed the title Fix test for corev1.LoadBalancerIngress,add IP model to VIP when ip i… [WIP] Fix test for corev1.LoadBalancerIngress,add IP model to VIP when ip i… Jul 5, 2024
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2024
@liangyuanpeng liangyuanpeng changed the title [WIP] Fix test for corev1.LoadBalancerIngress,add IP model to VIP when ip i… [WIP] Fix test for corev1.LoadBalancerIngress,add IP model to VIP when ip is setting. Jul 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.22%. Comparing base (26aae55) to head (e528cce).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5141      +/-   ##
==========================================
- Coverage   28.22%   28.22%   -0.01%     
==========================================
  Files         632      632              
  Lines       43553    43553              
==========================================
- Hits        12293    12291       -2     
- Misses      30364    30365       +1     
- Partials      896      897       +1     
Flag Coverage Δ
unittests 28.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng liangyuanpeng changed the title [WIP] Fix test for corev1.LoadBalancerIngress,add IP model to VIP when ip is setting. Fix test for corev1.LoadBalancerIngress,add IP model to VIP when ip is setting. Jul 5, 2024
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2024
@zhzhuang-zju
Copy link
Contributor

and i open a PR #5142 to adding the master branch to run karmada-apiserver compatibility workflow, So that we can find karmada-apiserver compatibility issues on the master branch.

Support, so that incompatibilities can be detected as early as possible

@zhzhuang-zju
Copy link
Contributor

That's weird, workflow e2e test(v1.30.0) fails too.

@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2024
@liangyuanpeng
Copy link
Contributor Author

Update the test for it, the feature gate LoadBalancerIPMode is beta at v1.30, see https://github.com/kubernetes/kubernetes/blob/95debfb5b6dcfa2467f2700d81df6767a2c91bac/pkg/features/kube_features.go#L903-L908

@zhzhuang-zju
Copy link
Contributor

@liangyuanpeng This change may need to be synchronized to release-1.10. Can you remind me why release-1.8 and release-1.9 are seems not affected? Refer to https://github.com/karmada-io/karmada/actions/runs/9734577204/job/26862785337, e2e test(release-1.8) and e2e test(release-1.9) all succeeded.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Jul 8, 2024

This change may need to be synchronized to release-1.10.

Yes

Can you remind me why release-1.8 and release-1.9 are seems not affected?

@zhzhuang-zju
This field (IPMode) is added in Kubernetes 1.29, it's mean client-go requires 0.29 k8s deps to see this field. the karmada 1.10 k8s deps version is v0.29.4 , so the service object have field of IPMode, and then test failed.

@zhzhuang-zju
Copy link
Contributor

@zhzhuang-zju This field (IPMode) is added in Kubernetes 1.29, it's mean client-go requires 0.29 k8s deps to see this field. the karmada 1.10 k8s deps version is v0.29.4 , so the service object have field of IPMode, and then test failed.

thanks, get it~

…s setting.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
Signed-off-by: Lan Liang <gcslyp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants