Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: delete the step for upgrade/downupgrade karmada-apiserver. #5142

Merged

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Jul 5, 2024

  • Add master branch to run workflow of karmada-apiserver compatibility.

What type of PR is this?

/kind cleanup
What this PR does / why we need it:

changes:

cc @zhzhuang-zju

Tested on my fork repo: https://github.com/liangyuanpeng/karmada/actions/runs/9802951091
And reason of workflow is failing is have a test need to update for karmada-apiserver 1.30, it's working at #5141

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


* Add master branch to run workflow of karmada-apiserver compatibility.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 5, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2024
@liangyuanpeng liangyuanpeng changed the title chore: delete the step for upgrade/downupgrade karmada-apiserver. ci: delete the step for upgrade/downupgrade karmada-apiserver. Jul 5, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.21%. Comparing base (c8acebc) to head (a422423).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5142   +/-   ##
=======================================
  Coverage   28.21%   28.21%           
=======================================
  Files         632      632           
  Lines       43568    43568           
=======================================
+ Hits        12291    12293    +2     
+ Misses      30381    30379    -2     
  Partials      896      896           
Flag Coverage Δ
unittests 28.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhzhuang-zju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@karmada-bot karmada-bot merged commit 26aae55 into karmada-io:master Jul 8, 2024
12 checks passed
@pulsarsigs-bot pulsarsigs-bot deleted the cleanup_ci_compatibility branch July 8, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants