test/e2e/karmadactl_test.go: test get command #5190
Conversation
karmada-bot
added
the
kind/failing-test
|
Welcome @mohamedawnallah! It looks like this is your first PR to karmada-io/karmada 🎉 |
karmada-bot
added
the
size/M
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5190 +/- ##
==========================================
- Coverage 28.25% 28.25% -0.01%
==========================================
Files 632 632
Lines 43723 43723
==========================================
- Hits 12354 12352 -2
- Misses 30467 30468 +1
- Partials 902 903 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mohamedawnallah
force-pushed
the
testKarmadactlGetCommand
branch
3 times, most recently
from
2ec588d
to
ab5d4c5
Compare
karmada-bot
added
size/L
mohamedawnallah
force-pushed
the
testKarmadactlGetCommand
branch
from
ab5d4c5
to
bdc9d35
Compare
mohamedawnallah
force-pushed
the
testKarmadactlGetCommand
branch
2 times, most recently
from
05d7a89
to
27ef0e9
Compare
|
/retest |
|
@mohamedawnallah: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
Hey @zhzhuang-zju, The test cases finished and all passed after addressing all the feedback :) |
|
/lgtm |
|
Please ping me once when it is time for merge this so I rebase :) |
There was a problem hiding this comment.
/approve
Hi @mohamedawnallah, this pr also need to rebase the master branch.
It can wait until the #5192 has been merged.
Other influential PRs are in a similar situation.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
/hold |
karmada-bot
added
the
do-not-merge/hold
In this commit, we test `karmadactl get` command on existing resource, non-existing resource, and invalid resource type. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah
force-pushed
the
testKarmadactlGetCommand
branch
from
27ef0e9
to
d2a47dd
Compare
|
Rebasing it now... Once the GitHub CI tests finish I will ask for review :) |
|
Thanks |
karmada-bot
removed
the
do-not-merge/hold
|
Hi @mohamedawnallah when you fix the comments, you can close it. |
@XiShanYongYe-Chang which comments? |
|
The CI tests finished and all passed. I'm gonna ask for review now, please let me if anything I'm missing before get merged :) |
|
Some comments made by others can be closed after the current modification. Some discussion comments can be closed after an agreement is reached with the commenter. |
|
/lgtm |
Description
In this commit, we test
karmadactl getcommand on existing resource, non-existing resource, and invalid resource type.What type of PR is this?
/kind failing-test
Which issue(s) this PR fixes:
Part of #4544
Does this PR introduce a user-facing change?: