Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e/karmadactl_test.go: test version command #5192

Merged
merged 1 commit into from
Jul 17, 2024
Merged

test/e2e/karmadactl_test.go: test version command #5192

merged 1 commit into from
Jul 17, 2024

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we test karmadactl version command to make sure it return valid information and return error when invalid flag is provided.

What type of PR is this?

/kind failing-test

Which issue(s) this PR fixes:

Part of #4544

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 13, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2024
@mohamedawnallah mohamedawnallah mentioned this pull request Jul 13, 2024
Open
31 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2024 •
edited

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.25%. Comparing base (a5070c7) to head (1fc977e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5192   +/-   ##
=======================================
  Coverage   28.25%   28.25%           
=======================================
  Files         632      632           
  Lines       43723    43723           
=======================================
+ Hits        12354    12355    +1     
+ Misses      30467    30466    -1     
  Partials      902      902
Flag Coverage Δ
unittests 28.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah force-pushed the testKarmadactlVersionCommand branch 2 times, most recently from 78ec6d3 to c9b583e Compare July 13, 2024 17:37
zhzhuang-zju
zhzhuang-zju reviewed Jul 15, 2024
View reviewed changes
test/e2e/karmadactl_test.go Outdated
gomega.Expect(strings.Contains(err.Error(), "unknown flag: --invalidflag")).Should(gomega.BeTrue())
})

ginkgo.It("should return the version information with kubeconfig", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohamedawnallah Is this test case necessary? karmadactl version doesn't actually use flag --kubeconfig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. When I started using the karmadactl options command, I found the flag --kubeconfig. However, you're correct that this is for testing something else and not the version command. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go ahead an remove it now!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks updated it!

@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2024
@zhzhuang-zju
Copy link
Contributor

/lgtm
thanks, cc @Vacant2333 @XiShanYongYe-Chang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@Vacant2333
Copy link
Contributor

hi, thanks, looks good to me
/approve

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vacant2333, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@XiShanYongYe-Chang
Copy link
Member

/hold

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@XiShanYongYe-Chang
Copy link
Member

Hi @mohamedawnallah there is a merge conflict, can you help rebase the master branch and push it again?

@mohamedawnallah
test/e2e/karmadactl_test.go: test version command
1fc977e 
In this commit, we test `karmadactl version` command to
make sure it return valid information and return error
when invalid flag is provided.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@mohamedawnallah
Copy link
Contributor Author

Rebased once the GitHub CI tests finish. I will ping you :)

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Jul 17, 2024
Merged
@XiShanYongYe-Chang
Copy link
Member

Thanks
/hold cancel
/lgtm

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@karmada-bot karmada-bot merged commit a5934ab into karmada-io:master Jul 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@Vacant2333 Vacant2333 Awaiting requested review from Vacant2333

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mohamedawnallah @codecov-commenter @zhzhuang-zju @Vacant2333 @karmada-bot @XiShanYongYe-Chang