Fix karmadactl addon failed to install karmada-scheduler-estimator due to unknown flag

[chaosi-zju]

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

fix launch arguments when install estimator by karmadactl which caused its installation failure

$ kubectl get pods -o wide -n karmada-system
...
karmada-system       karmada-scheduler-estimator-member4-774fd8d76c-skjj9            0/1     Error     1 (9s ago)   10s   10.91.0.17   karmada-karmadactl-host-control-plane   <none>           <none>
...

$ kubectl logs -f  karmada-scheduler-estimator-member4-774fd8d76c-skjj9 -n karmada-system                                                    
Usage:
  karmada-scheduler-estimator [flags]
...
Error: unknown flag: --client-cert-auth

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Fixed the issue that karmadactl addon failed to install karmada-scheduler-estimator due to unknown flag.

[chaosi-zju]

/cc @zhzhuang-zju

[zhzhuang-zju]

/assign

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.44%. Comparing base (4ac95b9) to head (e7db9d7).

Files with missing lines	Patch %	Lines
cmd/scheduler-estimator/app/options/options.go	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5523      +/-   ##
==========================================
- Coverage   32.45%   32.44%   -0.01%     
==========================================
  Files         643      643              
  Lines       44497    44497              
==========================================
- Hits        14440    14438       -2     
- Misses      28962    28963       +1     
- Partials     1095     1096       +1     

Flag	Coverage Δ
unittests	32.44% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chaosi-zju]

test report:

$ kubectl get pods -o wide -n karmada-system                         
NAME                                                   READY   STATUS    RESTARTS   AGE     IP            NODE                                    NOMINATED NODE   READINESS GATES
etcd-0                                                 1/1     Running   0          10m     10.187.0.5    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-aggregated-apiserver-7db6f685c6-kwr4z          1/1     Running   0          10m     10.187.0.7    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-apiserver-799cfbb68f-df99k                     1/1     Running   0          10m     10.187.0.6    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-controller-manager-ffc79cbf5-829dn             1/1     Running   0          8m48s   10.187.0.10   karmada-karmadactl-host-control-plane   <none>           <none>
karmada-descheduler-744f98cb8f-9jz8c                   1/1     Running   0          5m8s    10.187.0.13   karmada-karmadactl-host-control-plane   <none>           <none>
karmada-metrics-adapter-59cdb58586-w87xj               1/1     Running   0          4m20s   10.187.0.14   karmada-karmadactl-host-control-plane   <none>           <none>
karmada-scheduler-dbb6847f7-b64qv                      1/1     Running   0          9m17s   10.187.0.9    karmada-karmadactl-host-control-plane   <none>           <none>
karmada-scheduler-estimator-member4-5896d89644-gprzw   1/1     Running   0          3m5s    10.187.0.15   karmada-karmadactl-host-control-plane   <none>           <none>
karmada-search-6c4f64c474-kf4c7                        1/1     Running   0          6m7s    10.187.0.12   karmada-karmadactl-host-control-plane   <none>           <none>
karmada-webhook-666d8d6754-qx2fx                       1/1     Running   0          8m11s   10.187.0.11   karmada-karmadactl-host-control-plane   <none>           <none>
kube-controller-manager-787569d669-fmhnv               1/1     Running   0          9m19s   10.187.0.8    karmada-karmadactl-host-control-plane   <none>           <none>

[RainbowMango]

/retitle Fix karmadactl addon failed to install karmada-scheduler-estimator due to unknown flag

[RainbowMango]

This issue was introduced by #5040 ? mistakenly introduced not exist flag?

[chaosi-zju]

This issue was introduced by #5040 ? mistakenly introduced not exist flag?

Looks like it is

The --client-cert-auth=true seems to be the argument of etcd-server, estimator was not used.

[zhzhuang-zju]

@chaosi-zju Thank you for correcting my previous mistake.

This issue was introduced by #5040 ? mistakenly introduced not exist flag?

Yes, it seems that not all relevant parts were updated after the plan change. I will check to see if there are any remaining areas where this flag needs to be removed.

[zhzhuang-zju]

/lgtm
please cherry pick to release-1.11, thanks

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/scheduler-estimator/OWNERS [RainbowMango]
• pkg/karmadactl/addons/OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment