Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5523: Fix karmadactl addon failed to install karmada-scheduler-estimator due to unknown flag #5538

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Sep 13, 2024

Cherry pick of #5523 on release-1.11.
#5523: Fix karmadactl addon failed to install karmada-scheduler-estimator due to unknown flag
For details on the cherry pick process, see the cherry pick requests page.

`karmadactl`: Fixed the issue that karmadactl addon failed to install karmada-scheduler-estimator due to unknown flag.

Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2024
@chaosi-zju chaosi-zju changed the title Automated cherry pick of #5523: remove redundant launch arguments when install estimator by Automated cherry pick of #5523: Fix karmadactl addon failed to install karmada-scheduler-estimator due to unknown flag Sep 13, 2024
@chaosi-zju
Copy link
Member Author

/cc @zhzhuang-zju

@zhzhuang-zju
Copy link
Contributor

/lgtm
/assign @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.46%. Comparing base (79c1a6c) to head (9253626).

Files with missing lines Patch % Lines
cmd/scheduler-estimator/app/options/options.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11    #5538      +/-   ##
================================================
- Coverage         31.46%   31.46%   -0.01%     
================================================
  Files               643      643              
  Lines             44449    44449              
================================================
- Hits              13986    13984       -2     
- Misses            29438    29439       +1     
- Partials           1025     1026       +1     
Flag Coverage Δ
unittests 31.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@karmada-bot karmada-bot merged commit c7ae065 into karmada-io:release-1.11 Sep 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants