Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Support for resource scheduling suspend and resume capabilities #5690

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Proposal] Support for resource scheduling suspend and resume capabilities #5690

wants to merge 2 commits into from

Conversation

Vacant2333
Copy link
Contributor

What type of PR is this?

/kind design
/kind documentation

Which issue(s) this PR fixes:
Fixes #4937

Special notes for your reviewer:
Previous Proposal: #5118

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/design Categorizes issue or PR as related to design. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.93%. Comparing base (93a68eb) to head (ba71093).
Report is 36 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5690      +/-   ##
==========================================
+ Coverage   46.50%   47.93%   +1.43%     
==========================================
  Files         663      663              
  Lines       54740    54761      +21     
==========================================
+ Hits        25456    26252     +796     
+ Misses      27656    26801     -855     
- Partials     1628     1708      +80
Flag Coverage Δ
unittests 47.93% <ø> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vacant2333 Vacant2333 marked this pull request as ready for review October 15, 2024 01:33
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2024
@karmada-bot karmada-bot requested a review from Poor12 October 15, 2024 01:33
KunWuLuan
KunWuLuan reviewed Oct 24, 2024
View reviewed changes
docs/proposals/scheduling-suspension/README.md Outdated

// SuspendScheduling controls whether scheduling should be suspended.
// +optional
SuspendScheduling *bool `json:"suspendScheduling,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Scheduling is enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! do u have any more user case can share to me? i mean do u need this feat? thank u again.

@Monokaix
Copy link

Should also add rb status condition just like #5317.

@Vacant2333 @Monokaix
proposal-for-scheduling-suspension
b556f06 
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
@Monokaix Monokaix force-pushed the proposal-for-scheduling-suspension branch 5 times, most recently from 4e3260e to e0ca35f Compare December 3, 2024 01:53
kevin-wangzefeng
kevin-wangzefeng reviewed Dec 3, 2024
View reviewed changes
docs/proposals/scheduling-suspension/README.md Outdated
// Suspension declares the policy for suspending different aspects of propagation.
// nil means no suspension. no default values.
// +optional
// Suspension *policyv1alpha1.Suspension `json:"suspension,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Suspension *policyv1alpha1.Suspension `json:"suspension,omitempty"`
Suspension *policyv1alpha1.Suspension `json:"suspension,omitempty"`

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Monokaix
Update doc
ba71093 
Signed-off-by: Monokaix <changxuzheng@huawei.com>
@Monokaix Monokaix force-pushed the proposal-for-scheduling-suspension branch from e0ca35f to ba71093 Compare December 9, 2024 03:12
@Monokaix
Copy link

Monokaix commented Dec 9, 2024

/assign

@Monokaix Monokaix mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KunWuLuan KunWuLuan KunWuLuan left review comments

@Monokaix Monokaix Monokaix left review comments

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

@Tingtal Tingtal Awaiting requested review from Tingtal

@Poor12 Poor12 Awaiting requested review from Poor12

Assignees

@Monokaix Monokaix

Labels
kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support suspend ResourceBinding when create
6 participants
@Vacant2333 @karmada-bot @codecov-commenter @Monokaix @kevin-wangzefeng @KunWuLuan