Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cluster-level resource scheduling suspend and resume capabilities #5937

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Monokaix
Copy link

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Add rb suspension capability, background: #5690

Which issue(s) this PR fixes:
Fixes #5690

Special notes for your reviewer:
It extends the Suspension fileds and support rb susupend and resume, mostly like the previous issue #5217 and PRs implemented in it.

Does this PR introduce a user-facing change?:

Introduce cluster-level resource scheduling pause and resume capabilities

@karmada-bot karmada-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Dec 11, 2024
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 11, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot
Copy link
Collaborator

Welcome @Monokaix! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 11, 2024
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2024
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 11, 2024
@Monokaix Monokaix force-pushed the rb-suspend branch 2 times, most recently from c4d5f12 to 08407d6 Compare December 12, 2024 06:56
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2024
@Monokaix
Copy link
Author

@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 74.69880% with 21 lines in your changes missing coverage. Please review.

Project coverage is 48.21%. Comparing base (471d850) to head (06f2f66).

Files with missing lines Patch % Lines
pkg/controllers/binding/common.go 77.19% 10 Missing and 3 partials ⚠️
pkg/controllers/binding/binding_controller.go 0.00% 3 Missing and 1 partial ⚠️
...ers/binding/cluster_resource_binding_controller.go 0.00% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5937      +/-   ##
==========================================
+ Coverage   48.15%   48.21%   +0.05%     
==========================================
  Files         664      664              
  Lines       54803    54886      +83     
==========================================
+ Hits        26393    26464      +71     
- Misses      26693    26702       +9     
- Partials     1717     1720       +3     
Flag Coverage Δ
unittests 48.21% <74.69%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karmada-bot karmada-bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 12, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 12, 2024
Signed-off-by: Monokaix <changxuzheng@huawei.com>
Signed-off-by: Monokaix <changxuzheng@huawei.com>
Signed-off-by: Monokaix <changxuzheng@huawei.com>
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants