-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmadactl init: add CRDs archive verification to enhance file system robustness #5713
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5713 +/- ##
==========================================
- Coverage 46.30% 46.28% -0.03%
==========================================
Files 663 663
Lines 54686 54707 +21
==========================================
- Hits 25324 25322 -2
- Misses 27737 27760 +23
Partials 1625 1625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0c2028d
to
5c9e1db
Compare
5c9e1db
to
b61abdd
Compare
Wait for #5703 as the two PR will share common functions. |
… robustness Signed-off-by: zhzhuang-zju <m17799853869@163.com>
b61abdd
to
b7afcaf
Compare
done~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
karmadactl init
provides a custom download path for CRDs files. Before processing the files, it's necessary to validate the CRDs archive to enhance system robustness.check if its file name includes unclean paths.
check if the CRDs archive has the expected directory structure.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: