Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

vendor: Initialize the vendoring with dep tool #34

Closed
wants to merge 1 commit into from

Conversation

sboeuf
Copy link

@sboeuf sboeuf commented Dec 4, 2017

vendor: Initialize the vendoring with dep tool

This is the first commit related to the vendoring of all dependencies.
This will prevent from any breakage in case a dependency would break
the backward compatibility.

Fixes #32

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>

@sboeuf
Copy link
Author

sboeuf commented Dec 4, 2017

Fixes #32
cc @sameo @WeiZhang555 @laijs @gnawux @bergwolf

@WeiZhang555
Copy link
Member

WeiZhang555 commented Dec 5, 2017

I think we can add

[prune]
  go-tests = true

into Gopkg.toml to remove all "_test.go" test files as we don't need them for compilation.

Another option is unused-packages = true, but I'm not sure if it will make lots of differences.

@jodh-intel
Copy link
Contributor

@WeiZhang555 - good call! dep seems to have grown so new features recently:

@sboeuf
Copy link
Author

sboeuf commented Dec 5, 2017

@WeiZhang555 sure, I'll update that !

This is the first commit related to the vendoring of all dependencies.
This will prevent from any breakage in case a dependency would break
the backward compatibility.

Fixes #32

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
@sboeuf
Copy link
Author

sboeuf commented Dec 5, 2017

@WeiZhang555 @jodh-intel I have updated the PR. However, the _test.go files have not been removed from /vendor. I am wondering if this new feature is stable yet.

@jodh-intel
Copy link
Contributor

Well, the code to prune the test files looks pretty simple:

@bergwolf
Copy link
Member

bergwolf commented Dec 7, 2017

fyi, I submitted #48 to enable travis and noticed that there is no vendor in agent. So I took the liberty to add vendor support there as well. I can rebase #48 if this PR got merged first.

@bergwolf
Copy link
Member

The prune options in Gopkg.toml are used to control dep ensure behavior and they are not implemented yet. See golang/dep#944

@WeiZhang555
Copy link
Member

WeiZhang555 commented Dec 11, 2017

Maybe we can merge this first, in case it blocks others.

LGTM

Approved with PullApprove

@laijs
Copy link
Contributor

laijs commented Dec 11, 2017

It is cherry-picked in #48 , thank you! @sboeuf @bergwolf

@laijs laijs closed this Dec 11, 2017
@laijs laijs deleted the sboeuf/add_vendoring branch December 13, 2017 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants