This repository has been archived by the owner on May 12, 2021. It is now read-only.
mockserver locking, vsock address handling and CI #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bergwolf
commented
Dec 7, 2017
bergwolf
commented
- enable mock locking so that parallel client RPC does not cause data race.
- fix vsock address handling error due to url.URL vs. gRPC address format difference.
- enable travis ci for kata agent.
- add vendor so that travis can run properly.
Signed-off-by: Peng Tao <bergwolf@gmail.com>
URL format is <scheme>://<host>[:port]/<path>, while gRPC name syntax is <scheme>://<authority>/<endpoint_name>. Also if a unempty scheme is not supported by gRPC, gRPC ignores all the remaining part of the address and just pass an empty string to the dialer. Therefore we handcraft a self-defined vsock format vsock:<cid>:<port> to bypass gRPC parsing and let the vsock dialer parse the vsock gRPC address. Then we provide URL format based address interface to NewAgentClient() callers. Also add a few address tests to make sure this works. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
jodh-intel
reviewed
Dec 7, 2017
| go_import_path: github.com/kata-containers/agent | ||
|
|
||
| go: | ||
| - 1.8 |
There was a problem hiding this comment.
How about also adding the following?:
- 1.9
- tip
There was a problem hiding this comment.
I'm OK with both. Just note that other components are also using v1.8. If we want to go with v1.9 and tip, we should change others' travis settings as well.
There was a problem hiding this comment.
Ah - sorry, I forgot to check the other components. I'm happy to raise PRs to add these 2 versions in for the others if we all agree to use 1.9 and tip though?
There was a problem hiding this comment.
yeah, sounds good to me!
Merged
Merged
|
LGTM |
This is the first commit related to the vendoring of all dependencies. This will prevent from any breakage in case a dependency would break the backward compatibility. Fixes kata-containers#32 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
bergwolf
force-pushed
the
mock-locking
branch
from
716354c
to
6694a02
Compare
|
cherry-picked #34 as the last commit and CI passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.