Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

tracing: Add OpenTracing support #415

Merged
merged 10 commits into from
Mar 14, 2019
Merged

tracing: Add OpenTracing support #415

merged 10 commits into from
Mar 14, 2019
+20,022 −324

Commits on Mar 13, 2019

  1. agent: Properly stop the gRPC server 

    This commit attempts to close cleanly the gRPC server so that tracing
will be ended properly.

Fixes kata-containers#445

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
    @jodh-intel
    Sebastien Boeuf authored and jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    bbe06a4 View commit details
    Browse the repository at this point in the history

  2. service: Don't shutdown the VM when agent terminates 

    The semantic around the agent is that it should be a passive
component, hence it should not implicitly shut down the VM.

Instead, we expect the kata-runtime to be responsible for this,
using the appropriate VM interface to stop it.

Fixes kata-containers#449

Depends-on: github.com/kata-containers/tests#1101

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    Sebastien Boeuf authored and jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    272f273 View commit details
    Browse the repository at this point in the history

  3. build: Remove tabs 

    Tabs should only be used in rules.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    46ec60a View commit details
    Browse the repository at this point in the history

  4. build: Indent ifeq test 

    Reformat an `ifeq` test for clarity.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    30d98fe View commit details
    Browse the repository at this point in the history

  5. api: Remove unused variables 

    Detected by the CI's static analysis:

```
api.go:38:2:warning: unused variable or constant exitSuccess (varcheck)
api.go:39:2:warning: unused variable or constant exitFailure (varcheck)
api.go:38:2:warning: const exitSuccess is unused (U1000) (unused)
api.go:39:2:warning: const exitFailure is unused (U1000) (unused)
```

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    ab3e2c7 View commit details
    Browse the repository at this point in the history

  6. git: Don't ignore "agent" 

    This seems to be an erroneous / outdated entry as it's hiding
files below `vendor/`!

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    4383dbf View commit details
    Browse the repository at this point in the history

  7. docs: Update README 

    Firm up the language used in the README.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    5cc1df7 View commit details
    Browse the repository at this point in the history

  8. docs: Add debug options to README 

    Explain how to enable debug.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    0b7cae1 View commit details
    Browse the repository at this point in the history

  9. docs: Explain developer mode 

    Update the README to show how to enable developer mode.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    cbd0aae View commit details
    Browse the repository at this point in the history

  10. tracing: Add OpenTracing support 

    Add OpenTracing [1] support using Jaeger [2]. Introduces two new gRPC
API calls to enable and disable tracing dynamically: `StartTracing()`
and `StopTracing()`.

Full details of this feature are provided in `TRACING.md`.

Updated vendoring for github.com/mdlayher/vsock to resolve hangs using a
vsock socket with `grpcServer.Serve()`. Changes:

    498f144 Handle return result in Accept test
    fda437e Fix unblocking after closing listener
    4b12813 Add go.mod
    ce2ff06 vsock: factor out newConn function on Linux
    d8b0f13 vsock: adjust listener test for nonblocking
    7a158c6 vsock: enable timeouts also on listener connections
    f68ad55 vsock: allow timeouts with Go 1.11
    d0067a6 vsock/conn: don't use struct embedding

Note: the agent **must** be built with golang 1.11* or newer to ensure
correct behaviour.

Fixes kata-containers#322.

[1] - https://opentracing.io
[2] - https://jaegertracing.io

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
    @jodh-intel
    jodh-intel committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    00cf907 View commit details
    Browse the repository at this point in the history