agent: Add support for local storage #521
Conversation
|
@awprice thanks for raising this, please file an issue and include it in you commit message ( |
awprice
force-pushed
the
local-storage-type
branch
from
2b8b1c7
to
5c65b04
Compare
Thanks, done. |
|
/test |
|
Retriggering failing CI's.. |
mount.go
Outdated
| defer s.Unlock() | ||
| newStorage := s.setSandboxStorage(storage.MountPoint) | ||
| if newStorage { | ||
| return "", os.MkdirAll(storage.MountPoint, os.ModePerm) |
There was a problem hiding this comment.
Since it doesn't call commonStorageHandler please make sure readonly mount is handled.
There was a problem hiding this comment.
@bergwolf I've just added support for parsing and extracting the mode from storage.Options and using that when creating the directory. I've also added new tests for this functionality.
|
@chavafg @ganeshmaharaj Why is the linter failing on the vendored packages, we should not be checking those. |
|
I am not sure why they failed, but yes it is weird that it only failed on 2 jobs. any idea @ganeshmaharaj? |
|
@amshinde @chavafg it seems that we changed our vendor code recently. 39696c0. Not sure if we verified that all linter issues were resolved before landing it or if linter happens after updating the vendoring. this is just saying that our code has a an unkeyed field in our code. -- Update |
awprice
force-pushed
the
local-storage-type
branch
2 times, most recently
from
d0d8254
to
7e8dd3f
Compare
Local storage is just a directory created inside the VM. This will use whatever the storage driver is for the container rootfs. This will normally be 9p, but in some cases could be device mapper. In this case the directory will benefit from the improved performance of device mapper. Fixes kata-containers#524 Signed-off-by: Alex Price <aprice@atlassian.com>
awprice
force-pushed
the
local-storage-type
branch
from
7e8dd3f
to
8847998
Compare
| // Default to os.ModePerm. | ||
| opts := parseOptions(storage.Options) | ||
| mode := os.ModePerm | ||
| if val, ok := opts["mode"]; ok { |
There was a problem hiding this comment.
So we pass dir mode here. Please add the corresponding part in kata-containers/runtime#1485
There was a problem hiding this comment.
Thanks for the recommendation, I've updated the runtime PR with the mode.
|
/test |
|
/test |
|
@ganeshmaharaj @chavafg I've noticed some of the jenkins tests are still failing, are they related to the changes in my PR? Is there anything I can do to get them to pass? |
|
@awprice a quick glance at the test failure shows that |
|
hi, |
Local storage is just a directory created inside the VM.
This will use whatever the storage driver is for the container
rootfs. This will normally be 9p, but in some cases could be
device mapper. In this case the directory will benefit from the improved
performance of device mapper.
Signed-off-by: Alex Price aprice@atlassian.com