This repository has been archived by the owner on May 12, 2021. It is now read-only.
agent: send SIGKILL instead of SIGTERM to container init process #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
egernst
force-pushed
the
stable-1.5-backports
branch
from
b3b886b
to
52d6757
Compare
jcvenegas
approved these changes
Apr 16, 2019
|
/test |
If container initProcess doesn't install any handler for SIGTERM, it will ignore this signal, thus send it SIGKILL instead of SIGTERM to terminate it. Fixes:kata-containers#525 Signed-off-by: lifupan <lifupan@gmail.com>
|
The added unit test failed, not sure if need additional changes. |
|
probably needs kata-containers/runtime#1494 |
jodh-intel
approved these changes
Apr 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported:
c624f63 Merge pull request #526 from lifupan/stopfix
7fbd860 agent: send SIGKILL instead of SIGTERM to container init process
Not backported:
7720b93 Merge pull request #480 from jodh-intel/fix-user-initiated-shutdown
85e0942 docs: Explain shutdown behaviour with tracing
99d6118 docs: Define "VM" in tracing doc
353ec2d service: Fix user initiated shutdown with static tracing
34209ea Merge pull request #521 from awprice/local-storage-type
8847998 agent: Add support for local storage
bf5f5ab Merge pull request #529 from sboeuf/fix_exec_vndr
cb32d28 test: Fix mockContainer
3e12793 agent: Fix container creation
6e558f7 vendor: Update libcontainer vendoring
aa37186 Merge pull request #523 from teawater/static_build
8b34aaf make: Add build option STATIC=1 to statically link
801d792 Merge pull request #528 from teawater/lint
01b1cb2 travis: Use xenial
d815c97 lint: Update code to handle lint issues
828b417 ci: Update travis go version from 1.10 to 1.11