Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

docs: Add initcall_debug to dev guide debug section #205

Conversation

jodh-intel
Copy link
Contributor

kata-containers/runtime#527 Removed the
hard-coded initcall_debug kernel option (as it generates a lot of
kernel output at boot).

Add the initcall_debug option to the "Enable full debug" section to
allow users to enable these potentially useful messages when debugging.

Fixes #204.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

@jodh-intel
Copy link
Contributor Author

Once we have sufficient acks, this PR is definitely fasttrack-able as no prose changes ;)

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no problem with this, but I wonder how useful it will really be - has anybody had to debug the initcall sequence recently?
lgtm

@jodh-intel
Copy link
Contributor Author

Not I. But we do say "full debug" so it seems fair. Let's get input from @bergwolf.

kata-containers/runtime#527 Removed the
hard-coded `initcall_debug` kernel option (as it generates a lot of
kernel output at boot).

Add the `initcall_debug` option to the "Enable full debug" section to
allow users to enable these potentially useful messages when debugging.

Fixes kata-containers#204.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel force-pushed the add-initcall-debug-to-debug-info branch from 8b73c18 to c270496 Compare July 30, 2018 14:35
Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link
Contributor Author

Merging - we've got 2 approvals and it's a command-only change...

@jodh-intel jodh-intel merged commit 47a0d6a into kata-containers:master Aug 2, 2018
devimc pushed a commit to devimc/kata-documentation that referenced this pull request Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants