kernel: Remove initcall_debug boot option #527
Conversation
|
ping @devimc, @sboeuf, @grahamwhaley, @sameo, @bergwolf. |
|
PSS Measurement: Memory inside container: |
|
Build failed (third-party-check pipeline) integration testing with
|
|
I think the theory was we can add it into the existing toml 'kernel_args' param, and that would turn it on. |
|
@grahamwhaley I actually forgot that we had this option in the toml file. Sounds good :) |
|
let's merge once our CI gets back into shape. |
|
@jodh-intel please rebase as the CI fix was part of the runtime repo. |
|
LGTM! It would be good to see this integrated with |
jodh-intel
force-pushed
the
remove-initcall-debug-kernel-option
branch
from
c66c43b
to
db37c67
Compare
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 94 94
Lines 9678 9678
=======================================
Hits 6440 6440
Misses 2546 2546
Partials 692 692 |
kata-containers/runtime#527 Removed the hard-coded `initcall_debug` kernel option (as it generates a lot of kernel output at boot). Add the `initcall_debug` option to the "Enable full debug" section to allow users to enable these potentially useful messages when debugging. Fixes kata-containers#204. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
Re-pushed this branch to see what the CI makes of it this time. |
|
Build succeeded (third-party-check pipeline).
|
kata-containers/runtime#527 Removed the hard-coded `initcall_debug` kernel option (as it generates a lot of kernel output at boot). Add the `initcall_debug` option to the "Enable full debug" section to allow users to enable these potentially useful messages when debugging. Fixes kata-containers#204. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
@jodh-intel could you re-push in order to retrigger the whole CI? It's been stuck for no reason, and this PR should be merged :) |
Remove the `initcall_debug` boot option from the kernel command-line as we don't need it any more and it generates a ton of boot messages that may well be impacting performance. Fixes kata-containers#526. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
remove-initcall-debug-kernel-option
branch
from
db37c67
to
a8f5e2b
Compare
|
Re-pushed. I'm going to sacrifice a chocolate biscuit in my coffee for good luck too! |
|
PSS Measurement: Memory inside container: |
|
Build failed (third-party-check pipeline) integration testing with
|
|
All green except the expected openstack failure. |
|
@jodh-intel @egernst I think this might be a stable candidate since it relates to improving performances. WDYT? |
|
@sboeuf - no need - this is already in both stable branches ;) |
Update go version because golangci-lint v1.16.0 cannot work OK with go 1.10. Fixes: kata-containers#527 Signed-off-by: Hui Zhu <teawater@hyper.sh>
Update code to handle lint issues after golangci-lint update to v1.6.0. Fixes: kata-containers#527 Signed-off-by: Hui Zhu <teawater@hyper.sh>
Using xenial to handle the issue that using trusty in travis and go 1.11.7. Fixes: kata-containers#527 Signed-off-by: Hui Zhu <teawater@hyper.sh>
Remove the
initcall_debugboot option from the kernel command-line aswe don't need it any more and it generates a ton of boot messages that
may well be impacting performance.
Fixes #526.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com