Reuse existing messages when using MessagingStyle #1781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, users won't have to cache the messages in their Javascript code, the plugin will automatically check if there is an active notification with that ID and append the new messages to the existing ones. This will only be done when using MessagingStyle.
I decided to initialize the sender as "" instead of "Me" because this way users will be able to implement notifications for private conversations like in Telegram or WhatsApp, where the sender isn't displayed.
I also added the option to append the count of messages to the title, like messaging apps do.
Finally, I'm sending the app name as a tag to the notify call to make this plugin compatible with phonegap-plugin-push. Now both plugins will use the same tag, so they'll both be able to append new messages to the same notification when using MessagingStyle (I sent a PR to support MessagingStyle in that plugin).