Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add list and watch access for service accounts to cluster role #216

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

tomasspi
Copy link
Contributor

@tomasspi tomasspi commented Dec 17, 2021

Signed-off-by: tomasspi tom-300@hotmail.com

Added list and watch access for service accounts to keda-operator cluster role.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Relates to kedacore/keda#2406
Relates to kedacore/keda#2383

Signed-off-by: tomasspi <tom-300@hotmail.com>
@tomasspi tomasspi requested a review from a team as a code owner December 17, 2021 13:57
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this contribution

@JorTurFer JorTurFer requested a review from a team December 17, 2021 17:09
@tomkerkhove tomkerkhove merged commit 2a8b226 into kedacore:master Dec 20, 2021
@tomkerkhove tomkerkhove mentioned this pull request Dec 20, 2021
1 task
tomkerkhove added a commit to tomkerkhove/charts-1 that referenced this pull request Jan 4, 2022
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants