Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add list and watch access for service accounts to cluster role #2406

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

tomasspi
Copy link
Contributor

@tomasspi tomasspi commented Dec 17, 2021

Signed-off-by: tomasspi tom-300@hotmail.com

Added list and watch access for service accounts to keda-operator cluster role.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #2383

Signed-off-by: tomasspi <tom-300@hotmail.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the contribution

@JorTurFer JorTurFer merged commit 25ec884 into kedacore:main Dec 20, 2021
@JorTurFer JorTurFer added this to the v2.6.0 milestone Dec 20, 2021
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Jan 4, 2022
zroubalik pushed a commit that referenced this pull request Jan 4, 2022
alex60217101990 pushed a commit to dysnix/keda that referenced this pull request Jan 10, 2022
…edacore#2406)

Signed-off-by: tomasspi <tom-300@hotmail.com>
Signed-off-by: alex60217101990 <alex6021710@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does keda-operator ClusterRole need access to serviceaccounts?
3 participants