Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keda_scaler_metrics_latency #1034

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

kevinteng525
Copy link
Contributor

@kevinteng525 kevinteng525 commented Jan 6, 2023

  1. add keda_scaler_metrics_latency
  2. fix keda_scaled_object_errors

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#4040
Relates to kedacore/keda#4037

@kevinteng525 kevinteng525 requested a review from a team as a code owner January 6, 2023 09:52
@netlify
Copy link

netlify bot commented Jan 6, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 457f735
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/63b7efa5113c430008049e28
😎 Deploy Preview https://deploy-preview-1034--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

1. add keda_scaler_metrics_latency
2. fix keda_scaled_object_errors

Signed-off-by: kevin <tengkang@msn.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but waiting to merge until feature is merged

@zroubalik zroubalik merged commit bda67fa into kedacore:main Jan 6, 2023
@kevinteng525 kevinteng525 deleted the metrics branch January 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants