Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scaler metric latency support #4040

Merged
merged 6 commits into from
Jan 6, 2023
Merged

Add scaler metric latency support #4040

merged 6 commits into from
Jan 6, 2023

Conversation

kevinteng525
Copy link
Contributor

@kevinteng525 kevinteng525 commented Dec 25, 2022 •
edited by zroubalik
Loading

Add scaler metric latency support

Checklist

  • [ ] When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #4037
Relates to #4116

@kevinteng525 kevinteng525 requested a review from a team as a code owner December 25, 2022 12:17
@kevinteng525 kevinteng525 mentioned this pull request Dec 26, 2022
Closed
JorTurFer
JorTurFer reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!
Could you extend the metrics e2e test with these new metrics?
Update also the changelog please

zroubalik
zroubalik reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, please update changelog and add e2e tests as Jorge mentioned. Also please open a documentation PR with the new metrics.

And in the future, please don't delete the PR description template, as we use it to track items to be completed (the ones that we asked you about - docs, tests, changelog...).

pkg/prommetrics/adapter/adapter_prommetrics.go Outdated Show resolved Hide resolved
pkg/provider/provider.go Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

tomkerkhove commented Jan 3, 2023 •
edited
Loading

Can you also please update our documentation please and share an example of the outputted Prometheus metrics?

@kevinteng525
Add scaler metric latency support
be8886e 
Add scaler metric latency support

Signed-off-by: kevin <tengkang@msn.com>
@kevinteng525
Add e2e test
0ca2891 
Add e2e test

Signed-off-by: kevin <tengkang@msn.com>
@kevinteng525
Add changelog & fix static checks
fa18582 
Add changelog & fix static checks

Signed-off-by: kevin <tengkang@msn.com>
@kevinteng525
Copy link
Contributor Author

Added e2e test and updated CHANGELOG, will update doc as well

@kevinteng525
Fix scaled_object_errors
fad3925 
Fix scaled_object_errors

Signed-off-by: kevin <tengkang@msn.com>
@kevinteng525
move the logic for measuring latency inside cache.GetMetricsForScaler()
c62d21a 
move the logic for measuring latency inside cache.GetMetricsForScaler()

Signed-off-by: kevin <tengkang@msn.com>
@kevinteng525
Copy link
Contributor Author

Doc updated, kedacore/keda-docs#1034

@tomkerkhove tomkerkhove mentioned this pull request Jan 6, 2023
Merged
1 task
@kevinteng525
fix ut
e4ea07e 
fix ut

Signed-off-by: kevin <tengkang@msn.com>
@zroubalik
Copy link
Member

zroubalik commented Jan 6, 2023 •
edited by github-actions bot
Loading

/run-e2e prometheus_metrics*
Update: You can check the progress here

zroubalik
zroubalik approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great improvement!

@zroubalik zroubalik merged commit 3f57575 into kedacore:main Jan 6, 2023
@kevinteng525 kevinteng525 deleted the latency branch January 6, 2023 14:38
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Jan 9, 2023
@kevinteng525 @JorTurFer
Add scaler metric latency support (kedacore#4040)
0e3e3d6 
Signed-off-by: kevin <tengkang@msn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinteng525 @tomkerkhove @zroubalik @JorTurFer