Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite scaler docs #524

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Graphite scaler docs #524

merged 4 commits into from
Sep 15, 2021

Conversation

bpinske
Copy link
Contributor

@bpinske bpinske commented Sep 6, 2021

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1628

Signed-off-by: Brandon Pinske <brandon@pinske.info>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the file, so for example the Parameter list items description is more verbose.

Add more details to the metricName (as it is done for other scalers). More examples for queryTime would be great and does the value needs to be negative?

@zroubalik
Copy link
Member

And I don't see a section on auth

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
@bpinske
Copy link
Contributor Author

bpinske commented Sep 10, 2021

I don't see a section on auth
Could you please update the file, so for example the Parameter list items description is more verbose.

Add more details to the metricName (as it is done for other scalers). More examples for queryTime would be great and does the value needs to be negative?

All comments addressed. Verbosity is comparable to the Prometheus scaler.

Yes, the value does need to be a negative relative lookback time to be useful.
https://graphite-api.readthedocs.io/en/latest/api.html#from-until

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
content/docs/2.5/scalers/graphite.md Outdated Show resolved Hide resolved
content/docs/2.5/scalers/graphite.md Outdated Show resolved Hide resolved
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
@zroubalik zroubalik merged commit fe5f86e into kedacore:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants