-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite scaler docs #524
Graphite scaler docs #524
Conversation
Signed-off-by: Brandon Pinske <brandon@pinske.info>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the file, so for example the Parameter list items description is more verbose.
Add more details to the metricName
(as it is done for other scalers). More examples for queryTime
would be great and does the value needs to be negative?
And I don't see a section on |
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
All comments addressed. Verbosity is comparable to the Prometheus scaler. Yes, the value does need to be a negative relative lookback time to be useful. |
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Provide a description of what has been changed
Checklist
Fixes #1628