-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite Scaler + e2e tests #2092
Conversation
01f42f7
to
669a451
Compare
7440a1a
to
899b195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bpinske! I had started to look at the e2e tests a couple of times but had yet to make much progress.
6e9b257
to
95fcb43
Compare
c286084
to
54e0783
Compare
7a5e4f0
to
aff37c6
Compare
Co-authored-by: 刘烁 <shuo.liu@leyantech.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: shuoliu1 shuo_liu1@163.com Signed-off-by: Brandon Pinske <brandon@pinske.info> Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
aff37c6
to
c28f28f
Compare
Signed-off-by: Brandon Pinske <brandon@pinske.info> Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
c28f28f
to
7c73477
Compare
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bpinske for completing this feature!
Co-authored-by: shuoliu1 <shuo_liu1@163.com> Co-authored-by: 刘烁 <shuo.liu@leyantech.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com> Signed-off-by: shuoliu1 shuo_liu1@163.com Signed-off-by: Brandon Pinske <brandon@pinske.info> Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Co-authored-by: shuoliu1 <shuo_liu1@163.com> Co-authored-by: 刘烁 <shuo.liu@leyantech.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com> Signed-off-by: shuoliu1 shuo_liu1@163.com Signed-off-by: Brandon Pinske <brandon@pinske.info> Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Support scaling by Graphite Metrics
Checklist
Graphite scaler docs keda-docs#524
Fixes #1628