Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite Scaler + e2e tests #2092

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Graphite Scaler + e2e tests #2092

merged 4 commits into from
Sep 15, 2021

Conversation

bpinske
Copy link
Contributor

@bpinske bpinske commented Sep 6, 2021

Support scaling by Graphite Metrics

Checklist

Fixes #1628

Copy link

@nmische nmische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bpinske! I had started to look at the e2e tests a couple of times but had yet to make much progress.

pkg/scalers/graphite_scaler.go Outdated Show resolved Hide resolved
CREATE-NEW-SCALER.md Outdated Show resolved Hide resolved
pkg/scalers/graphite_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/graphite_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/graphite_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/graphite_scaler.go Outdated Show resolved Hide resolved
tests/scalers/graphite-deployment.yaml Show resolved Hide resolved
@bpinske bpinske force-pushed the graphite-wip branch 5 times, most recently from 7a5e4f0 to aff37c6 Compare September 13, 2021 18:21
Co-authored-by: 刘烁 <shuo.liu@leyantech.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: shuoliu1 shuo_liu1@163.com
Signed-off-by: Brandon Pinske <brandon@pinske.info>
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Signed-off-by: Brandon Pinske <brandon@pinske.info>
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
pkg/scalers/graphite_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/graphite_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/graphite_scaler_test.go Outdated Show resolved Hide resolved
Brandon Pinske added 2 commits September 14, 2021 17:23
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bpinske for completing this feature!

@zroubalik zroubalik merged commit ebd8e28 into kedacore:main Sep 15, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Co-authored-by: shuoliu1 <shuo_liu1@163.com>
Co-authored-by: 刘烁 <shuo.liu@leyantech.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com>

Signed-off-by: shuoliu1 shuo_liu1@163.com
Signed-off-by: Brandon Pinske <brandon@pinske.info>
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
bpinske added a commit to bpinske/keda that referenced this pull request Jan 19, 2022
Co-authored-by: shuoliu1 <shuo_liu1@163.com>
Co-authored-by: 刘烁 <shuo.liu@leyantech.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com>

Signed-off-by: shuoliu1 shuo_liu1@163.com
Signed-off-by: Brandon Pinske <brandon@pinske.info>
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphite 支持
4 participants