Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eventhub scaler docs with information for non public clouds. #719

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Mar 22, 2022

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Update eventhub scaler docs with information for non public clouds.
kedacore/keda#2788

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #
kedacore/keda#1915

@netlify
Copy link

netlify bot commented Mar 22, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit f40989d
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/623a204e891fc60008dc4606
😎 Deploy Preview https://deploy-preview-719--keda.netlify.app/docs/2.7/scalers/azure-event-hub
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JorTurFer
Copy link
Member

Hi @v-shenoy
Thanks for this!! Could you rebase main? There is a commit that solves Netlify error

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
some nits inline

content/docs/2.7/scalers/azure-event-hub.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-event-hub.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/azure-event-hub.md Outdated Show resolved Hide resolved
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ❤️

@zroubalik zroubalik merged commit beed31f into kedacore:main Mar 22, 2022
@v-shenoy v-shenoy deleted the non-public-clouds branch March 22, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants