Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-public clouds for EventHub scaler. #2788

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Mar 22, 2022

Added support for three new fields in the trigger metadata for the eventhub scaler. The cloud parameter can be azureChinaCloud, azureGermanCloud, azureUSGovernmentCloud, azurePublicCloud, or private (default is azurePublicCloud).

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: eventhub
  labels: {}
spec:
  scaleTargetRef:
    name: eventhub
  triggers:
  - type: azure-eventhub
    metadata:
      direction: in
      eventHubNamespace: non-public-clouds-ns
      eventHubName: python-hub
      consumerGroup: $Default
      storageConnectionFromEnv: AzureWebJobsStorage
      cloud: "private"
      endpointSuffix: <service-bus-suffix>
      activeDirectoryEndpoint: <ad-endpoint>
    authenticationRef:
      name: eventhub-trigger-auth
---

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #1915, #2781

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy requested a review from a team as a code owner March 22, 2022 09:44
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
only small nits inline
Thanks for this improvement! ❤️

pkg/scalers/azure_eventhub_scaler.go Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 0ef96ad into kedacore:main Mar 22, 2022
@v-shenoy v-shenoy deleted the non-public-clouds-eventhub branch March 22, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support non-public clouds for Azure Event Hub
3 participants