-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite Scaler doesn't properly handle null responses #2944
Labels
bug
Something isn't working
Comments
5 tasks
JorTurFer
pushed a commit
that referenced
this issue
Apr 29, 2022
* Return latest non-null graphite data point. Don't mis-interpret null as zero Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> * Use the changelog properly Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> * Add test case, fix a lint failure Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> * Use the changelog properly Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> * I'll learn how to use a changelog one day. Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Repository owner
moved this from In Progress
to Ready To Ship
in Roadmap - KEDA Core
Apr 29, 2022
1 task
bamboo12366
pushed a commit
to bamboo12366/keda
that referenced
this issue
Apr 30, 2022
(kedacore#2945) * Return latest non-null graphite data point. Don't mis-interpret null as zero Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> * Use the changelog properly Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> * Add test case, fix a lint failure Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> * Use the changelog properly Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> * I'll learn how to use a changelog one day. Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Report
In some configurations, it's possible for Graphite to return null for its latest datapoint. This gets erroneously interpeted as a zero.
Expected Behavior
Nulls are tolerated with the most recent non-null datapoint being used instead.
Nulls should not be mis-interpeted as a zero value
Actual Behavior
Null graphite responses cause apps to erroneously scale down.
Steps to Reproduce the Problem
Logs from KEDA operator
No response
KEDA Version
No response
Kubernetes Version
No response
Platform
No response
Scaler Details
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: