Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Graphite Scaler doesn't properly handle null responses #2944 #2945

Merged
merged 5 commits into from
Apr 29, 2022
Merged

Fix Graphite Scaler doesn't properly handle null responses #2944 #2945

merged 5 commits into from
Apr 29, 2022

Conversation

bpinske
Copy link
Contributor

@bpinske bpinske commented Apr 28, 2022 •
edited by JorTurFer
Loading

Do not mis-interpet null as zero
Use the latest non-null returned value in a query response

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2944

@bpinske bpinske requested a review from a team as a code owner April 28, 2022 00:54
Return latest non-null graphite data point. Don't mis-interpret null …
3a91c24 
…as zero

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Use the changelog properly
2dc5cdc 
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
tomkerkhove
tomkerkhove reviewed Apr 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/graphite_scaler.go Show resolved Hide resolved
Brandon Pinske added 3 commits April 28, 2022 15:48
Add test case, fix a lint failure
3251095 
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Use the changelog properly
2ebb08f 
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
I'll learn how to use a changelog one day.
c92f8c0 
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
JorTurFer
JorTurFer approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this fix ❤️

@JorTurFer JorTurFer merged commit 85e8382 into kedacore:main Apr 29, 2022
JorTurFer added a commit that referenced this pull request Apr 30, 2022
@JorTurFer
Revert "Fix Graphite Scaler doesn't properly handle null responses #2944
763542f 
 (#2945)"

This reverts commit 85e8382.
@JorTurFer JorTurFer mentioned this pull request Apr 30, 2022
Merged
1 task
bamboo12366 pushed a commit to bamboo12366/keda that referenced this pull request Apr 30, 2022
@bpinske @bamboo12366
Fix Graphite Scaler doesn't properly handle null responses kedacore#2944
4eb936c 
 (kedacore#2945)

* Return latest non-null graphite data point. Don't mis-interpret null as zero

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>

* Use the changelog properly

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>

* Add test case, fix a lint failure

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>

* Use the changelog properly

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>

* I'll learn how to use a changelog one day.

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>

Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphite Scaler doesn't properly handle null responses
3 participants
@bpinske @tomkerkhove @JorTurFer