Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for explicitly pausing autoscaling of ScaledJobs #3303

Closed
tomkerkhove opened this issue Jun 30, 2022 · 6 comments · Fixed by #4558
Closed

Provide support for explicitly pausing autoscaling of ScaledJobs #3303

tomkerkhove opened this issue Jun 30, 2022 · 6 comments · Fixed by #4558
Labels
feature All issues for new features that have been committed to

Comments

@tomkerkhove
Copy link
Member

tomkerkhove commented Jun 30, 2022

Proposal

Provide support for explicitly pausing autoscaling of ScaledJobs so that it no longer spins up new jobs.

This should be done by applying the autoscaling.keda.sh/paused: true annotation on the ScaledJobs resource.

Use-Case

Avoid scaling when:

  • Cluster is having resource starvation
  • Doing maintenance
  • ...

Anything else?

Follow-up for #944

@keegancwinchester
Copy link

I am interested in contributing to this issue! I will begin to work on this.

@tomkerkhove
Copy link
Member Author

Thank you @keeganwinchester-shipt!

@zroubalik
Copy link
Member

autoscaling.keda.sh/is-paused: true - I personally don't like the is- part of this at all. It gives me an impression that it describes a state rather than setting the action.

I'd use autoscaling.keda.sh/paused: true instead

@tomkerkhove @JorTurFer ^^

@tomkerkhove
Copy link
Member Author

Fine by me, I thought that was what we agreed on but I'll update the spec

@JorTurFer
Copy link
Member

I agree

@tomkerkhove
Copy link
Member Author

This is being worked on by @flux-benj in #3303

@tomkerkhove tomkerkhove moved this from To Do to In Progress in Roadmap - KEDA Core May 23, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment