Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce is-paused annotation for ScaledJobs #3652

Closed
wants to merge 0 commits into from
Closed

Introduce is-paused annotation for ScaledJobs #3652

wants to merge 0 commits into from

Conversation

keegancwinchester
Copy link

Introduce annotation "autoscaling.keda.sh/is-paused" for ScaledJobs.

Checklist

  • When introducing a new scaler, I agree with the scaling governance policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

#Relates to #3303

@keegancwinchester keegancwinchester requested a review from a team as a code owner September 8, 2022 12:57
@JorTurFer
Copy link
Member

Hey,
There are a lot of changes in the PR unrelated with it. Maybe your branch is outdated somehow... Could you sync your PR rebasing main branch?

@keegancwinchester
Copy link
Author

@JorTurFer Yes, I originally didn't sign my commit so I followed the rebasing instruction and I think it messed some things up. I will retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keegancwinchester @JorTurFer