-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use e2e testing infrastructure #3753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
changed the title
WIP - feath: Use new environment variables
WIP - feat: Use new environment variables autogenerated
Oct 15, 2022
JorTurFer
force-pushed
the
switch-to-tf
branch
3 times, most recently
from
November 8, 2022 23:16
abe0a7b
to
18d207a
Compare
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer
force-pushed
the
switch-to-tf
branch
from
November 8, 2022 23:29
18d207a
to
0ea6f66
Compare
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
JorTurFer
changed the title
WIP - feat: Use new environment variables autogenerated
feat: Use new environment variables autogenerated
Nov 11, 2022
JorTurFer
changed the title
feat: Use new environment variables autogenerated
feat: Use e2e testing infrastructure
Nov 11, 2022
JorTurFer
force-pushed
the
switch-to-tf
branch
2 times, most recently
from
November 11, 2022 11:50
9ec7da4
to
cb6a124
Compare
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
JorTurFer
force-pushed
the
switch-to-tf
branch
from
November 11, 2022 11:51
cb6a124
to
e74368f
Compare
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
zroubalik
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Jan 18, 2023
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
This PR changes the e2e infrastructure to use the new resources managed by terraform in https://github.com/kedacore/testing-infrastructure and improves also how we managed the secrets automatically creating environment variables for each secret, removing the requirement of creating a PR enabling new secrets (now automatically generated from infrastructure repository)
Checklist
Relates to kedacore/governance#77