Backport fixes to release 2.8 #4135

pedro-stanaka · 2023-01-18T07:59:56Z

I am backporting a list of fixes to the release 2.8, so we can tag and release a patch version 2.8.2.

Relates to #4132

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

zroubalik · 2023-01-18T09:14:59Z

@pedro-stanaka could you please run make clientset-generate on this branch and make a new commit containing this change?

pedro-stanaka · 2023-01-18T09:19:50Z

@zroubalik I did that before when I saw the output from CI, but I did not get any diff:

zroubalik · 2023-01-18T09:26:55Z

oh I see, there's an itendation problem in those files caused by different go versions and operating systems :( 🤯 It has been resolved recently. So we should hack this:

Could you please copy these files from release/v2.8 branch to your local branch and commit them into this PR?
Here are direct links to correctly intended files:
https://github.com/kedacore/keda/blob/12783c1340a13ba6776d1d6a64127d88e7828aab/pkg/generated/clientset/versioned/fake/register.go
https://github.com/kedacore/keda/blob/12783c1340a13ba6776d1d6a64127d88e7828aab/pkg/generated/clientset/versioned/scheme/register.go

pedro-stanaka · 2023-01-18T10:08:12Z

oh I see, there's an itendation problem in those files caused by different go versions and operating systems :( 🤯 It has been resolved recently. So we should hack this:

Could you please copy these files from release/v2.8 branch to your local branch and commit them into this PR? Here are direct links to correctly intended files: https://github.com/kedacore/keda/blob/12783c1340a13ba6776d1d6a64127d88e7828aab/pkg/generated/clientset/versioned/fake/register.go https://github.com/kedacore/keda/blob/12783c1340a13ba6776d1d6a64127d88e7828aab/pkg/generated/clientset/versioned/scheme/register.go

CI seems happier now, I forgot which step failed before, but I think it passed now.

zroubalik · 2023-01-18T10:09:43Z

@JorTurFer we should probably also fix those security problems identified by Trivy, right?

zroubalik · 2023-01-18T10:16:57Z

@pedro-stanaka could you please enforce update of the packages identified in the check: https://github.com/kedacore/keda/actions/runs/3947682302/jobs/6756786914 ?

pedro-stanaka · 2023-01-18T10:18:06Z

Sure thing. Let me try it.

zroubalik · 2023-01-18T10:26:49Z

@pedro-stanaka it is better to do it through replace directive (at least for the go net package)

keda/go.mod

Line 92 in a25f1a4

replace (

pedro-stanaka · 2023-01-18T10:32:49Z

Hum this CVE: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMAWSAWSSDKGOSERVICES3S3CRYPTO-598253
sounds like a false-positive. We are on 1.44 and it says it should be resolved in 1.34+.

Edit: I see we have the same problem in main, but for some reason it passes there. I also see that main is using a config file instead of the cli args.

zroubalik · 2023-01-18T15:03:38Z

/run-e2e
Update: You can check the progress here

pedro-stanaka · 2023-01-18T15:35:05Z

@zroubalik seems like some configuration problem of CI here again. Did I forget to port something?

zroubalik · 2023-01-18T16:55:59Z

@JorTurFer ^

zroubalik · 2023-01-18T16:56:23Z

it's most likely configuration error on our side

JorTurFer · 2023-01-18T18:06:06Z

I have to check because there are multiple things failing...
You can ignore these missing checks, it's normal because they are checks introduced in main branch

WRT e2e test, it's something that it's failing, and I have an idea (I think it's related with the migration to the new testing-infrastructure repo), I need to check it better.

Trivy check is still failing due to aws dep

JorTurFer · 2023-01-18T18:31:31Z

For solving e2e test, this PR is required. Let me cherry-pick it before and then rebase your branch

pedro-stanaka · 2023-01-18T19:41:45Z

I can rebase as well, just let me know when you rebased your PR.

JorTurFer · 2023-01-18T21:10:00Z

I can rebase as well, just let me know when you rebased your PR.

I have already merged the PR into release/v2.8 branch, please rebase your branch from it

pkg/scalers/mongo_scaler.go

pkg/scalers/datadog_scaler.go

pkg/scalers/stackdriver_client.go

pkg/scalers/mongo_scaler.go

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

…3694) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

…ore#3762) * fix(prometheus scaler): Detect Inf before casting float to int Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Improve the log message Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

…red (waiting for ack) towards keda value (kedacore#3809) * fix: keda now include the messages that should be retried in the count of pending messages used for scaling Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com> * chore: update changelog Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com> Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

…re#3788) * Update stackdriver client to handle metrics of value type double Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> * move change log note to below general Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> * parse activation value as float64 Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> * change target value to float64 for GCP pub/sub and stackdriver Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

Signed-off-by: ytz <1020560484@qq.com> Signed-off-by: taenyang <1020560484@qq.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com> Signed-off-by: Tony Lee <tony.lee@shopback.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Tony Lee <tony.lee@shopback.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

Fixes kedacore#3992 Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

JorTurFer · 2023-01-19T09:46:01Z

/run-e2e
Update: You can check the progress here

JorTurFer · 2023-01-19T11:35:04Z

/run-e2e redis_standalone*
Update: You can check the progress here

JorTurFer · 2023-01-19T11:35:17Z

/run-e2e cassandra*
Update: You can check the progress here

JorTurFer · 2023-01-19T11:35:28Z

/run-e2e predictkube*
Update: You can check the progress here

JorTurFer · 2023-01-19T12:56:32Z

Thanks for your help @pedro-stanaka

pedro-stanaka requested a review from a team as a code owner January 18, 2023 07:59

pedro-stanaka mentioned this pull request Jan 18, 2023

Release v2.8.2 #4132

Closed

1 task

pedro-stanaka force-pushed the feat/backport-fixes-to-2.8 branch from e390189 to c7e830a Compare January 18, 2023 08:32

pedro-stanaka force-pushed the feat/backport-fixes-to-2.8 branch from 7e9cb62 to 75e3e1c Compare January 19, 2023 06:28