New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/datadog-scaler-null-last-point #3954

Merged

zroubalik merged 16 commits into kedacore:main from dogzzdogzz:fix/datadog-scaler-null-last-point

Dec 8, 2022

Contributor

dogzzdogzz commented Dec 5, 2022 •

edited

Loading

In issue 3906, we found out that the last data point of some specific query always returns null, this fix is to find out the last data point which is not null instead of validating the last data point only

Checklist

Commits are signed with Developer Certificate of Origin (DCO - learn more)
Changelog has been updated and is aligned with our changelog requirements

Fixes #3906


          fix/datadog-scaler-null-last-point

7d17261

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

dogzzdogzz requested a review from a team as a code owner

December 5, 2022 06:46


          check point's length

0c5a9b0

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

zroubalik requested changes

View reviewed changes

Member

zroubalik left a comment

Looking good, could you please unit test for this? Should be trivial, there are some existig tests already, thanks!

https://github.com/kedacore/keda/blob/main/pkg/scalers/datadog_scaler_test.go#L55-L86

CHANGELOG.md Outdated Show resolved Hide resolved

dogzzdogzz added 2 commits

December 5, 2022 16:40


          sort changelog alphabetically

ea9fca1

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>


          add unit test

1cb1d06

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

Contributor Author

dogzzdogzz commented Dec 5, 2022

@zroubalik unit test added, could you review it ?


          remove redudant code

8fb0d68

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

dogzzdogzz requested a review from zroubalik

December 5, 2022 09:27

dogzzdogzz added 2 commits

December 5, 2022 17:33


          update change log comment

894966f

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>


          add newline

db9293c

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

JorTurFer reviewed

View reviewed changes

pkg/scalers/datadog_scaler.go Outdated Show resolved Hide resolved

tonylee-shopback and others added 3 commits

December 8, 2022 09:44


          Merge branch 'main' into fix/datadog-scaler-null-last-point

36979e4

Signed-off-by: Tony Lee <tony.lee@shopback.com>


          rename the iterator

6ddddcd

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>


          feature/datadog-scaler-timeWindowOffset-and-timeWindowOffset (#1)

f862d0f

* feature/datadog-scaler-timeWindowOffset-and-timeWindowOffset

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

* fix bug

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

dogzzdogzz requested review from JorTurFer and zroubalik and removed request for zroubalik and JorTurFer

December 8, 2022 07:30


          remove comment

392afae

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

dogzzdogzz mentioned this pull request

[Datadog scaler] Scaler returns fillValue if the last data point of query is null #3906

Closed

dogzzdogzz added 2 commits

December 8, 2022 16:34


          fix static check err

97dc26a

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>


          fix static check err

f14fbee

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

Member

zroubalik commented Dec 8, 2022

@dogzzdogzz could you please fix the Static Check?


          fix static check err

1559e6d

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>

Member

zroubalik commented Dec 8, 2022

@dogzzdogzz the problem is still there :(

Member

zroubalik commented Dec 8, 2022

@dogzzdogzz you can probably add exception for this check here: https://github.com/kedacore/keda/blob/main/.golangci.yml#L63

dogzzdogzz and others added 2 commits

December 8, 2022 22:57


          exclude datadog_scaler.go from static check

fce4899


          Merge branch 'main' into fix/datadog-scaler-null-last-point

9a0f9e1

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

Member

zroubalik commented Dec 8, 2022 •

edited by github-actions bot

Loading

/run-e2e datadog*
Update: You can check the progress here

Contributor Author

dogzzdogzz commented Dec 8, 2022

static check passed, thanks for the suggestion

zroubalik approved these changes

View reviewed changes

zroubalik merged commit 455eab3 into kedacore:main

JorTurFer mentioned this pull request

Release v2.8.2 #4132

Closed

1 task

pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request


          fix/datadog-scaler-null-last-point (kedacore#3954)

b822e30

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
Signed-off-by: Tony Lee <tony.lee@shopback.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Tony Lee <tony.lee@shopback.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>

pedro-stanaka mentioned this pull request

Backport fixes to release 2.8 #4135

Merged

7 tasks

pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request


          fix/datadog-scaler-null-last-point (kedacore#3954)

b4ae488

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
Signed-off-by: Tony Lee <tony.lee@shopback.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Tony Lee <tony.lee@shopback.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request


          fix/datadog-scaler-null-last-point (kedacore#3954)

9d17c13

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
Signed-off-by: Tony Lee <tony.lee@shopback.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Tony Lee <tony.lee@shopback.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request


          fix/datadog-scaler-null-last-point (kedacore#3954)

5c55da6

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
Signed-off-by: Tony Lee <tony.lee@shopback.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Tony Lee <tony.lee@shopback.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

JorTurFer added a commit that referenced this pull request


          Backport fixes to release 2.8 (#4135)

e0ba57d

* fix: CVE-2022-3172 (#3693)

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

* fix: Respect optional parameter inside envs for ScaledJobs (#3694)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

* fix(prometheus scaler): Detect Inf before casting float to int (#3762)

* fix(prometheus scaler): Detect Inf before casting float to int

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Improve the log message

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

* fix(nats-jetstream): correctly count messages that should be redelivered (waiting for ack) towards keda value (#3809)

* fix: keda now include the messages that should be retried in the count of pending messages used for scaling

Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com>

* chore: update changelog

Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com>

Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

* NewRelic scaler crashes on logging (#3946)

Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com>

Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

* Fix stackdriver client returning 0 for metric types of double (#3788)

* Update stackdriver client to handle metrics of value type double

Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com>

* move change log note to below general

Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com>

* parse activation value as float64

Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com>

* change target value to float64 for GCP pub/sub and stackdriver

Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com>

Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

* Fixing conflicts after cherry-pick

Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

* fix: Close is called twice on PushScaler's deletion (#3599)

Signed-off-by: ytz <1020560484@qq.com>
Signed-off-by: taenyang <1020560484@qq.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

* fix/datadog-scaler-null-last-point (#3954)

Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
Signed-off-by: Tony Lee <tony.lee@shopback.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Tony Lee <tony.lee@shopback.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

* fix(mongodb): escape username and password (#3989)

Fixes #3992

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

* Hacking generated files to version CI expects

Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>

* Updating aws-sdk and golang packages to fix CVEs

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

* Updating golang/text package to fix CVE

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

* Using same version of aws sdk as in main

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com>
Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com>
Signed-off-by: ytz <1020560484@qq.com>
Signed-off-by: taenyang <1020560484@qq.com>
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
Signed-off-by: Tony Lee <tony.lee@shopback.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Antoine LAFFARGUE <antoine.laffargue@gmail.com>
Co-authored-by: Laszlo Kishalmi <laszlo.kishalmi@gmail.com>
Co-authored-by: Eric Takemoto <eric.takemoto@gocrisp.com>
Co-authored-by: taenyang <1020560484@qq.com>
Co-authored-by: Tony Lee <dogzzdogzz@gmail.com>
Co-authored-by: Tony Lee <tony.lee@shopback.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet