webhook: cache miss fallback to direct client for ScaledObject #6186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
wozniakjan
force-pushed
the
webhook/cache_miss_fallback_to_direct_client
branch
from
9895f0d to
0796a20
Compare
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
wozniakjan
force-pushed
the
webhook/cache_miss_fallback_to_direct_client
branch
from
0796a20 to
6d38faf
Compare
|
for helm, this is just a matter of extraArgs:
webhooks:
cache-miss-to-direct-client: "true" |
1 task
JorTurFer
approved these changes
Sep 27, 2024
|
/run-e2e |
|
/run-e2e internal |
|
I think that the failure is related with this PR and not with your changes -> #6196 |
|
/run-e2e internal |
|
/run-e2e internal |
|
/run-e2e internal |
|
/run-e2e azureeventgridtopic |
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 21, 2024
…ore#6186) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
…ore#6186) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: michael pechner <mike.pechner@akasa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating
DeploymentandScaledObjectas part of a single helm chart / manifests file, it's possible to hit a race condition when webhook rejectsScaledObjectbecause the cached kubernetes client doesn't see theDeploymentyet. This PR adds a fallback option with--cache-miss-to-direct-clientcommand line parameter, when set to true, if there was a cache miss (GETreturned errorIsNotFound), validating webhook will attempt the sameGETbut using the direct REST kubernetes client.Checklist
Fixes #5973