Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EventGrid event emiter e2e test doesn't fail randomly #6196

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

keda-automation
Copy link
Member

Currently, the test fails randomly, as it only verifies the last emitted event from all the recovered. As other events could be sent, we should verify all of them and fail only if any event is the expected one

https://github.com/kedacore/keda/actions/runs/11076398611/job/30785120281

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@keda-automation keda-automation requested a review from a team as a code owner September 27, 2024 22:47
@kedacore kedacore deleted a comment from keda-automation Sep 27, 2024
@JorTurFer
Copy link
Member

JorTurFer commented Sep 27, 2024

/run-e2e azureeventgridtopic_test
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@zroubalik zroubalik enabled auto-merge (squash) October 2, 2024 19:26
@JorTurFer
Copy link
Member

JorTurFer commented Oct 2, 2024

/run-e2e azureeventgridtopic_test
Update: You can check the progress here

@zroubalik zroubalik merged commit 6cd5198 into kedacore:main Oct 2, 2024
18 checks passed
@JorTurFer JorTurFer deleted the fix-e2e- branch October 2, 2024 23:39
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
…6196)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Co-authored-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
…6196)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Co-authored-by: Jorge Turrado <jorge_turrado@hotmail.es>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
…6196)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Co-authored-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants