Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaler typed config: simplify missing parameter error #6194

Conversation

wozniakjan
Copy link
Member

@rickbrouwer noticed that #5997 introduced a small side effect with how TypedConfig returns errors for missing trigger metadata parameter names.

error parsing XYZ metadata: unable to set param ["abc"] value

This PR improves the readability of the error by going back to

error parsing XYZ metadata: unable to set param "abc" value

and alternatively listing multiple parameter names as just comma-separated

error parsing XYZ metadata: unable to set param "Abc,abc" value

Checklist

  • Tests have been added
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan requested a review from a team as a code owner September 27, 2024 12:56
@SpiritZhou
Copy link
Contributor

I used to think that using brackets was a way to indicate that it can support multiple names. But now it seems that omitting the brackets can make the text more readable. :)

@wozniakjan wozniakjan merged commit 69a9cb9 into kedacore:main Sep 29, 2024
19 of 22 checks passed
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 2, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 2, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants