Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move test requirements to optional dependencies in pyproject.toml #263

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

sbrugman
Copy link
Contributor

@sbrugman sbrugman commented Jul 10, 2023

Description

Fixes open todos:

Development notes

Closes kedro-org/kedro#1498 and closes #169

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@sbrugman sbrugman force-pushed the test-requirements branch 3 times, most recently from 449ce92 to 89be6b4 Compare July 10, 2023 22:46
@astrojuanlu astrojuanlu changed the title Chore: Move test requirements to optional dependencies in pyproject.toml chore: Move test requirements to optional dependencies in pyproject.toml Jul 11, 2023
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks a lot @sbrugman!

The biggest change is going from our big dynamic setup.py in kedro-datasets to having all optional dependencies using self-referential requirements. I am personally a fan of this approach, but I am deferring to the engineering team to do the final approval.

@astrojuanlu

This comment was marked as resolved.

@ankatiyar ankatiyar added the Community Issue/PR opened by the open-source community label Jul 13, 2023
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super neat! ⭐ Thank you so much @sbrugman ! I left one question, but other than that I'm happy to get this merged.

I don't think it fully closes kedro-org/kedro#1498 yet because we'll need to remove any dataset related dependencies from the core repo for the 0.19.0 release, but it's definitely reduced the task.

kedro-airflow/features/environment.py Show resolved Hide resolved
Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
@sbrugman
Copy link
Contributor Author

sbrugman commented Jul 20, 2023

Rebased the changes on top of the pre-commit.

@merelcht Could we merge this and then take on purging related dependencies from the core repo for the 0.19.0 release separately?

(Fully moving to pyproject.toml and supporting python 3.11 in both projects are chores that we can get done soon)

Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
@merelcht
Copy link
Member

@merelcht Could we merge this and then take on purging related dependencies from the core repo for the 0.19.0 release separately?

(Fully moving to pyproject.toml and supporting python 3.11 in both projects are chores that we can get done soon)

Yes absolutely. We are not working on any 0.19.0 changes yet, to ensure that the main and develop branches won't diverge too much. Likely we'll kick that all off end of summer.

DimedS added a commit that referenced this pull request Aug 17, 2023
…roject.toml (#263)"

This reverts commit 73262bc.

revert 263 chore: Move test requirements to optional dependencies in pyproject.toml
DimedS added a commit that referenced this pull request Aug 17, 2023
…roject.toml (#263)"

This reverts commit 73262bc.

revert 263 chore: Move test requirements to optional dependencies in pyproject.toml

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
PtrBld pushed a commit to PtrBld/kedro-plugins that referenced this pull request Aug 27, 2023
…oml (kedro-org#263)

* Chore: Move test requirements to optional dependencies in pyproject.toml

Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>

* Chore: Refactor setup.py for static dependencies

Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>

* Chore: Replace setup.py with pyproject.toml

Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>

* chore: remove `requirements-fixer` from pre-commit

Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>

---------

Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community
Projects
None yet
4 participants